Skip to content

Conversation

@joein
Copy link
Member

@joein joein commented Dec 2, 2025

numpy has dropped python3.10 as of 2.3.0, and introduced support for 3.14 in the same release

@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

📝 Walkthrough

Walkthrough

This pull request updates numpy dependency constraints in pyproject.toml to extend Python version support from 3.10-3.13 to 3.10-3.14. The existing three per-Python-version entries are replaced with five new version-specific constraints, each with corresponding numpy version bounds ranging from >=1.21,<2.3.0 for Python 3.10-3.11 to >=2.3.0 for Python >=3.14. The constraint for Python <3.10 remains unchanged. Onnxruntime and other dependencies are unaffected.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Single file modification (pyproject.toml) with straightforward dependency constraint updates
  • Changes are homogeneous in nature (consistent pattern of version constraint replacements)
  • Requires verification that numpy version bounds are accurate and compatible with each Python version range
  • Pay particular attention to the new Python 3.14 entry and the transition between version constraints to ensure no gaps or overlaps exist

Suggested reviewers

  • tbung

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: updating numpy dependency constraints to account for numpy 2.3.0 dropping Python 3.10 support.
Description check ✅ Passed The description accurately relates to the changeset, explaining the rationale for the numpy dependency updates: numpy 2.3.0 dropped 3.10 support and added 3.14 support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-numpy-versioning

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ba8990 and 3ed836d.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Python 3.9.x on windows-latest test
  • GitHub Check: Python 3.13.x on windows-latest test
🔇 Additional comments (1)
pyproject.toml (1)

17-21: The constraints are correct. NumPy 2.3.0 dropped Python 3.10 support but maintains support for Python 3.11, 3.12, and 3.13, with planned support for Python 3.14. The version bounds appropriately reflect this:

  • Line 17 correctly restricts Python 3.10 to versions below 2.3.0
  • Lines 18–20 correctly allow Python 3.11–3.13 unrestricted access to numpy 2.3.0+
  • Line 21 correctly sets the minimum to 2.3.0 for Python 3.14, aligning with planned support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@joein joein requested a review from tbung December 4, 2025 04:30
@joein joein merged commit 3511b08 into main Dec 5, 2025
17 checks passed
@joein joein deleted the fix-numpy-versioning branch December 5, 2025 11:08
kacperlukawski pushed a commit to kacperlukawski/fastembed that referenced this pull request Dec 15, 2025
* fix: numpy dropped 3.10 as of 2.3.0

* fix: update poetry lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants