Skip to content

Conversation

@bashofmann
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
mkdocs.yml (1)

50-94: Consolidate duplicate markdown_extensions sections.

The configuration contains two markdown_extensions: declarations (lines 50 and 89). In YAML, the second occurrence will override the first, causing the extensions in the first block (abbr, admonition, attr_list, def_list, toc) to be lost. Merge these sections into a single markdown_extensions: block to preserve all extensions.

 markdown_extensions:
   - abbr
   - admonition
   - attr_list
   # - highlight
   - def_list
   - toc:
       permalink: true
       toc_depth: 3
+  - pymdownx.superfences:
+      custom_fences:
+        - name: mermaid
+          class: mermaid
+          format: !!python/name:pymdownx.superfences.fence_code_format

-markdown_extensions:
-  - pymdownx.superfences:
-      custom_fences:
-        - name: mermaid
-          class: mermaid
-          format: !!python/name:pymdownx.superfences.fence_code_format
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 685fd9b and 198a79e.

⛔ Files ignored due to path filters (1)
  • docs/assets/favicon.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • mkdocs.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Python 3.11.x on ubuntu-latest test
  • GitHub Check: Python 3.10.x on ubuntu-latest test
  • GitHub Check: Python 3.13.x on macos-latest test
  • GitHub Check: Python 3.13.x on windows-latest test
  • GitHub Check: Python 3.12.x on ubuntu-latest test
  • GitHub Check: Python 3.13.x on ubuntu-latest test

theme:
name: material
logo: assets/favicon.png
favicon: assets/favicon.png
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# First, check if favicon.png exists in the repository
echo "=== Checking for favicon.png ==="
find . -name 'favicon.png' -type f 2>/dev/null

echo ""
echo "=== Checking assets directory structure ==="
find . -name 'assets' -type d 2>/dev/null | head -10

echo ""
echo "=== Full path to any png files in assets directories ==="
find . -path '*/assets/*.png' 2>/dev/null

Repository: qdrant/fastembed

Length of output: 261


🏁 Script executed:

#!/bin/bash
# Read the full mkdocs.yml file to verify structure and completeness
echo "=== Full mkdocs.yml file content ==="
cat -n mkdocs.yml

Repository: qdrant/fastembed

Length of output: 3006


Fix duplicate markdown_extensions section causing first block to be ignored.

The favicon asset exists and is correctly configured. However, the mkdocs.yml file has duplicate markdown_extensions: blocks at lines 50 and 89. In YAML, the second declaration overrides the first, meaning the extensions from lines 50-58 (abbr, admonition, attr_list, def_list, toc) are not loaded. Merge both blocks into a single markdown_extensions: section to preserve all extensions.

🤖 Prompt for AI Agents
In mkdocs.yml (around lines 50-58 and 89), there are two markdown_extensions:
blocks causing the first block (lines ~50-58: abbr, admonition, attr_list,
def_list, toc) to be ignored by the later block at ~89; merge both declarations
into a single markdown_extensions: section that includes all unique entries from
both blocks (preserve order where relevant), remove the duplicate block, and
ensure YAML syntax/indentation is correct so all extensions are loaded.

@joein joein self-requested a review December 18, 2025 13:22
@bashofmann bashofmann merged commit 020d535 into main Dec 18, 2025
13 checks passed
@bashofmann bashofmann deleted the update-favicon branch December 18, 2025 14:49
@qdrant qdrant deleted a comment from coderabbitai bot Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants