Skip to content

Add snapshot duration field in QdrantClusterSnapshot status #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hossainemruz merged 4 commits into from
Nov 20, 2024
Merged

Add snapshot duration field in QdrantClusterSnapshot status #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e44aca
Add snapshot duration field in QdrantClusterSnapshot status
hossainemruz Nov 19, 2024
049ff22
Add IsCompleted() heleper
hossainemruz Nov 19, 2024
8a610ff
Rename Duration to CompletionTime
hossainemruz Nov 19, 2024
f47d59c
Added comment about duration format
hossainemruz Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions api/v1/qdrantclustersnapshot_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ type QdrantClusterSnapshotStatus struct {
// The calculated time (in UTC) this snapshot will be deleted, if so.
// +optional
RetainUntil *metav1.Time `json:"retainUntil,omitempty"`
// CompletionTime specifies how long it took for the snapshot to complete
// When serialized, it is a Duration in string format which follows "DDdHHhMMmSSs" format
// For example: "1d3h5m10s", "3h5m10s", "5m10s", "10s" etc.
// +optional
CompletionTime *metav1.Duration `json:"completionTime,omitempty"`
}

type VolumeSnapshotInfo struct {
Expand All @@ -66,6 +71,7 @@ type VolumeSnapshotInfo struct {
// +kubebuilder:printcolumn:name="clusterid",type=string,JSONPath=`.spec.cluster-id`
// +kubebuilder:printcolumn:name="Phase",type=string,JSONPath=`.status.phase`
// +kubebuilder:printcolumn:name="retainUntil",type=string,JSONPath=`.status.retainUntil`
// +kubebuilder:printcolumn:name="completion-time",type=string,JSONPath=`.status.completionTime`
// +kubebuilder:printcolumn:name="age",type=date,JSONPath=`.metadata.creationTimestamp`

// QdrantClusterSnapshot is the Schema for the qdrantclustersnapshots API
Expand All @@ -77,6 +83,10 @@ type QdrantClusterSnapshot struct {
Status QdrantClusterSnapshotStatus `json:"status,omitempty"`
}

func (qcs *QdrantClusterSnapshot) IsCompleted() bool {
return qcs.Status.Phase == SnapshotSucceeded || qcs.Status.Phase == SnapshotFailed || qcs.Status.Phase == SnapshotSkipped
}

//+kubebuilder:object:root=true

// QdrantClusterSnapshotList contains a list of QdrantClusterSnapshot
Expand Down
5 changes: 5 additions & 0 deletions api/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions charts/qdrant-kubernetes-api/templates/region-crds/qdrant.io_qdrantclustersnapshots.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ spec:
- jsonPath: .status.retainUntil
name: retainUntil
type: string
- jsonPath: .status.completionTime
name: completion-time
type: string
- jsonPath: .metadata.creationTimestamp
name: age
type: date
Expand Down Expand Up @@ -83,6 +86,12 @@ spec:
type: object
status:
properties:
completionTime:
description: |-
CompletionTime specifies how long it took for the snapshot to complete
When serialized, it is a Duration in string format which follows "DDdHHhMMmSSs" format
For example: "1d3h5m10s", "3h5m10s", "5m10s", "10s" etc.
type: string
phase:
enum:
- Running
Expand Down
Loading