Fix flipping QdrantCluster.Spec.ServicePerNode from false to true
#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value for the field is `true`, and it is omitted from the serialized output if the field is set to false. Hence, it is possible to flip value from `true` to `false` in the following scenario: * client submits to k8s API server with `ServicePerNode=false` * client fetch the persisted instance from k8s API server, given that `false` for a boolean is considered empty, `ServicePerNode` field does not appear in the received payload. * client updates the payload and sends it back the k8s API server. Given that `ServicePerNode` is not present in the payload, k8s API server is going to flip it to the default value, which is `true` To correct this, `omitempty` tag is removed for `ServicePerNode` field, so that the field is always present in the serialized output.
hossainemruz
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for the field is
true, and it is omitted from the serialized output if the field is set to false. Hence, it is possible to flip value fromtruetofalsein the following scenario:ServicePerNode=falsefalsefor a boolean is considered empty,ServicePerNodefield does not appear in the received payload.ServicePerNodeis not present in the payload, k8s API server is going to flip it to the default value, which istrueTo correct this,
omitemptytag is removed forServicePerNodefield, so that the field is always present in the serialized output.