Skip to content

refactor: Store num-workers in the offset key #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anush008 merged 1 commit into from
Dec 3, 2025
Merged

refactor: Store num-workers in the offset key #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cmd/migrate_from_qdrant.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,9 +458,10 @@ func (r *MigrateFromQdrantCmd) migrateDataParallel(ctx context.Context, sourceCl

var totalProcessed uint64
// If not restarting, load the progress for each range.
// The offset key includes NumWorkers, so changing num-workers will start a fresh migration.
if !r.Migration.Restart {
for i := range ranges {
offsetKey := fmt.Sprintf("%s-range-%d", sourceCollection, ranges[i].id)
offsetKey := fmt.Sprintf("%s-workers-%d-range-%d", sourceCollection, r.NumWorkers, ranges[i].id)
offsetID, count, err := commons.GetStartOffset(ctx, r.Migration.OffsetsCollection, targetClient, offsetKey)
if err != nil {
return fmt.Errorf("failed to get start offset: %w", err)
Expand Down Expand Up @@ -507,7 +508,7 @@ func (r *MigrateFromQdrantCmd) migrateDataParallel(ctx context.Context, sourceCl
// migrateRange is the function executed by each worker in parallel migration.
// It scrolls through a specific range of points and upserts them to the target.
func (r *MigrateFromQdrantCmd) migrateRange(ctx context.Context, sourceCollection, targetCollection string, sourceClient, targetClient *qdrant.Client, rg rangeSpec, shardKeys *sync.Map, bar *pterm.ProgressbarPrinter) error {
offsetKey := fmt.Sprintf("%s-range-%d", sourceCollection, rg.id)
offsetKey := fmt.Sprintf("%s-workers-%d-range-%d", sourceCollection, r.NumWorkers, rg.id)
offset := rg.start
var count uint64

Expand Down
Loading