Skip to content

feat: Support Milvus partition names #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anush008 merged 1 commit into from
May 20, 2025
Merged

feat: Support Milvus partition names #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,15 @@ docker run --net=host --rm -it registry.cloud.qdrant.io/library/qdrant-migration

| Flag | Description |
| -------------------------- | ------------------------------------------------------- |
| `--milvus.url` | Source Milvus URL (e.g. `https://your-milvus-hostname`) |
| `--milvus.collection` | Source collection name |
| `--milvus.api-key` | Source API key (`$SOURCE_API_KEY`) |
| `--milvus.enable-tls-auth` | Enable TLS Auth |
| `--milvus.url` | Milvus URL (e.g. `https://your-milvus-hostname`) |
| `--milvus.collection` | Milvus collection name |
| `--milvus.api-key` | Milvus API key for authentication |
| `--milvus.enable-tls-auth` | Whether to enable TLS Auth |
| `--milvus.username` | Username for Milvus |
| `--milvus.password` | Password for Milvus |
| `--milvus.db-name` | Milvus database name |
| `--milvus.server-version` | Server version |
| `--milvus.db-name` | Optional database name |
| `--milvus.server-version` | Milvus server version |
| `--milvus.partitions` | List of partition names |

#### Qdrant Options

Expand Down
1 change: 1 addition & 0 deletions cmd/migrate_from_milvus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ func (r *MigrateFromMilvusCmd) migrateData(ctx context.Context, sourceClient *mi
}

result, err := sourceClient.Query(ctx, milvusclient.NewQueryOption(r.Milvus.Collection).
WithPartitions(r.Milvus.Partitions...).
WithFilter(filter).
WithOutputFields("*").
WithLimit(batchSize))
Expand Down
17 changes: 9 additions & 8 deletions pkg/commons/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@ type MigrationConfig struct {
}

type MilvusConfig struct {
Url string `help:"Source Milvus URL, e.g. https://your-milvus-hostname" required:"true"`
Collection string `help:"Source collection" required:"true"`
APIKey string `help:"Source API key"`
EnableTLSAuth bool `help:"Enable TLS Auth for Milvus" default:"false"`
Username string `help:"Milvus username"`
Password string `help:"Milvus password"`
DBName string `help:"Milvus database name"`
ServerVersion string `help:"Milvus server version"`
Url string `help:"Source Milvus URL, e.g. https://your-milvus-hostname" required:"true"`
Collection string `help:"Source collection" required:"true"`
APIKey string `help:"Source API key"`
EnableTLSAuth bool `help:"Enable TLS Auth for Milvus" default:"false"`
Username string `help:"Milvus username"`
Password string `help:"Milvus password"`
DBName string `help:"Milvus database name"`
ServerVersion string `help:"Milvus server version"`
Partitions []string `help:"Milvus partition names"`
}

type PineconeConfig struct {
Expand Down
Loading