Add buf-plugin-method-options plugin
#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areina
force-pushed
the
feat/toni/add-method-options-plugin
branch
2 times, most recently
from
7309b5b to
70721bf
Compare
Add a plugin that checks that RPC methods define a set of options that are currently required for Qdrant Cloud APIs. At this moment, the list of required options is: - `google.api.http` - `qdrant.cloud.common.v1.permissions`
areina
force-pushed
the
feat/toni/add-method-options-plugin
branch
from
70721bf to
39e3740
Compare
Robert-Stam
approved these changes
Apr 2, 2025
Contributor
Robert-Stam
left a comment
Robert-Stam
left a comment
There was a problem hiding this comment.
Very nice, LGTM.
PS: We need to enable this only at the public API, not the internal-api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a plugin that checks that RPC methods define a set of options that are currently required for Qdrant Cloud APIs. At this moment, the list of required options is:
google.api.httpqdrant.cloud.common.v1.permissions