-
Notifications
You must be signed in to change notification settings - Fork 85
feature: alvinramoutar/support-global-additionalLabels #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: alvinramoutar/support-global-additionalLabels #401
Conversation
cbc68be to
a288408
Compare
TestStatefulSetLabelsTestIngressLabelsTestServiceAccountLabels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good. Thanks for the contribution.
Could you please remove the version bump and the changes from the changelogs from this PR? We will add these, when we prepare a release with the next Qdrant patch release.
Also, please run gofmt to make the linter happy.
431bb4d to
0b04cfd
Compare
Appreciate the review @bashofmann , updated. |
|
Is there a way I could trigger PR workflows @bashofmann ? |
|
I fixed the failing test in #424. Thank you for your contribution. |
See #400 .
Notes: