Check if server's and client's versions are compatible#206
Merged
Conversation
tellet-q
force-pushed
the
check-version-on-init
branch
from
80fb4fa to
29c5f97
Compare
timvisee
reviewed
Jan 2, 2025
tellet-q
force-pushed
the
check-version-on-init
branch
from
e722b92 to
d1c5141
Compare
tellet-q
changed the title
timvisee
force-pushed
the
check-version-on-init
branch
from
22f050b to
3b53ff7
Compare
Member
|
I fixed the test by creating a new client for the check 🤷 |
tellet-q
changed the title
timvisee
reviewed
Jan 10, 2025
timvisee
approved these changes
Jan 10, 2025
timvisee
added a commit
that referenced
this pull request
Jan 16, 2025
* Check versions compatibility during init * Add tests * Fetch server version using futures * Do async health check in sync context * Check compatibility in temporary thread * create dedicated client to avoid 'Service was not ready' * fmt * Use semver crate * Fix linter --------- Co-authored-by: timvisee <tim@visee.me> Co-authored-by: Arnaud Gourlay <arnaud.gourlay@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send request to fetch server version during init and compare with client version.
Introduce a boolean param
check_compatibility(true by default). If it is true -> check versions during client init and generate a warning if versions are not compatible. Add public methodskip_compatibility_checkto skip the check:Qdrant::from_url("http://localhost:6334").skip_compatibility_check().build();Compatible versions are the ones that differ by one, i.e client version 1.6.x is compatible with server versions 1.5.x and 1.7.x but not 1.4.x or 1.8.x.