Conversation
timvisee
changed the title
agourlay
approved these changes
Jan 16, 2025
Member
agourlay
left a comment
agourlay
left a comment
There was a problem hiding this comment.
I have validated this branch by using it in coach and crasher.
Everything looks good 👍
Member
Author
|
Merging this so I can prepare the release PR |
timvisee
added a commit
that referenced
this pull request
Jan 16, 2025
* Update gRPC protocol buffer definitions * Generate gRPC types, update builders and conversions * Add max optimization threads builder * Add bool index params builder * Add has vector condition builder * Add dense, sparse and multi dense vector builders and conversions * Remove has vector condition builder, follow pattern of other conditions
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the protocol definitions and all related structures to match our upcoming Qdrant release.
This adds quite a few builders for new types, and makes the necessary changes to glue everything together (with minimal breakage).
It excludes builders and integrations for the new inference API types such as Document and Object. Those will be implemented once we actually release the feature.
Example of reworked max optimization threads interface in documentation, also supporting the previous raw number:
All Submissions:
devbranch. Did you create your branch fromdev?