Skip to content

Conversation

@Maki-Grz
Copy link

This PR resolves issue #258 where the Qdrant client was successfully built even if the server was unreachable due to the "lazy" nature of gRPC channels.
Changes:

  • Added connect() method in ChannelPool to explicitly trigger make_channel() and the underlying Tonic connection.
  • Exposed pub async fn connect(&self) in the Qdrant client for users to eagerly verify connectivity.
  • Added an integration test snippet in tests/snippets/connect.rs to verify that connect() correctly returns an error on invalid URLs.

All Submissions:

  • Contributions should target the dev branch.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests?

New Feature Submissions:

  1. Does your submission pass tests? (Verified locally)
  2. Have you formatted your code locally using cargo +nightly fmt --all?
  3. Have you checked your code using cargo clippy --all --all-features?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why?
  • Have you written new tests for your core changes?
  • Have you successfully ran tests with your changes locally?

- Implemented connect() in ChannelPool to force channel initialization
- Added pub async fn connect() to Qdrant client
- Added integration test to verify failure on invalid URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant