-
Notifications
You must be signed in to change notification settings - Fork 77
implement helper for specifying per-request tracing #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+76
−0
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| mod test_batch_update; | ||
| mod test_clear_payload; | ||
| mod test_collection_exists; | ||
| mod test_config_headers; | ||
| mod test_count_points; | ||
| mod test_create_collection; | ||
| mod test_create_collection_with_bq; | ||
|
|
@@ -21,7 +20,6 @@ mod test_delete_snapshot; | |
| mod test_delete_vectors; | ||
| mod test_discover_batch_points; | ||
| mod test_discover_points; | ||
| mod test_external_api_keys; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same. |
||
| mod test_facets; | ||
| mod test_get_collection; | ||
| mod test_get_collection_aliases; | ||
|
|
@@ -59,3 +57,4 @@ mod test_upsert_points; | |
| mod test_upsert_points_fallback_shard_key; | ||
| mod test_upsert_points_insert_only; | ||
| mod test_upsert_points_with_condition; | ||
| mod test_with_header; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
|
|
||
| #[tokio::test] | ||
| async fn test_with_header() { | ||
| async fn with_header() -> Result<(), Box<dyn std::error::Error>> { | ||
| // WARNING: This is a generated test snippet. | ||
| // Please, modify the snippet in the `../snippets/with_header.rs` file | ||
| use qdrant_client::Qdrant; | ||
|
|
||
| let client = Qdrant::from_url("http://localhost:6334") | ||
| .header("x-base", "base-value") | ||
| .skip_compatibility_check() | ||
| .build() | ||
| .unwrap(); | ||
|
|
||
| let traced = client.with_header("x-request-id", "abc-123"); | ||
|
|
||
| assert_eq!( | ||
| traced.config.custom_headers, | ||
| vec![ | ||
| ("x-base".to_string(), "base-value".to_string()), | ||
| ("x-request-id".to_string(), "abc-123".to_string()), | ||
| ] | ||
| ); | ||
| // Original still has only the base header | ||
| assert_eq!( | ||
| client.config.custom_headers, | ||
| vec![("x-base".to_string(), "base-value".to_string())] | ||
| ); | ||
| Ok(()) | ||
| } | ||
| let _ = with_header().await; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| use qdrant_client::Qdrant; | ||
|
|
||
| let client = Qdrant::from_url("http://localhost:6334") | ||
| .header("x-base", "base-value") | ||
| .skip_compatibility_check() | ||
| .build() | ||
| .unwrap(); | ||
|
|
||
| let traced = client.with_header("x-request-id", "abc-123"); | ||
|
|
||
| assert_eq!( | ||
| traced.config.custom_headers, | ||
| vec![ | ||
| ("x-base".to_string(), "base-value".to_string()), | ||
| ("x-request-id".to_string(), "abc-123".to_string()), | ||
| ] | ||
| ); | ||
| // Original still has only the base header | ||
| assert_eq!( | ||
| client.config.custom_headers, | ||
| vec![("x-base".to_string(), "base-value".to_string())] | ||
| ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@generall why these tests are deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is autogenerated, I would need to look into it