Skip to content

Conversation

@iceseer
Copy link
Contributor

@iceseer iceseer commented Jan 30, 2025

Referenced issues

Description of the Change

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

Signed-off-by: iceseer <[email protected]>
@kamilsa kamilsa requested review from kamilsa and xDimon and removed request for xDimon February 20, 2025 09:14
Comment on lines +116 to +119
SL_TRACE(logger,
"[Peer View storages statistics]:"
"\n\t-> remote_view={}",
remote_veiw_size);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use single-line messages, at least over several messages? Messages with line-breaks can spoil log or break works some log-readers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants