Add KAGOME minority tests for PVF preparation and BEEFY voting #2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds new tests for KAGOME minority nodes for both PVF preparation and BEEFY voting scenarios.
- Introduces two new configuration files: one for PVF preparation (0001-parachains-pvf-kagome-minority.toml) and one for BEEFY voting (0003-beefy-and-mmr-kagome-minority.toml).
- Updates the zombie-tests workflow to include the new KAGOME minority tests.
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| zombienet/polkadot/functional/0003-beefy-and-mmr-kagome-minority.toml | Adds configuration for BEEFY voting with KAGOME minority nodes. |
| zombienet/polkadot/functional/0001-parachains-pvf-kagome-minority.toml | Adds configuration for PVF preparation with KAGOME minority nodes. |
| .github/workflows/zombie-tests.yaml | Updates test matrix to include new KAGOME minority test cases. |
Files not reviewed (3)
- zombienet/docker/Makefile.include/zombietests.mk: Language not supported
- zombienet/polkadot/functional/0001-parachains-pvf-kagome-minority.zndsl: Language not supported
- zombienet/polkadot/functional/0003-beefy-and-mmr-kagome-minority.zndsl: Language not supported
zombienet/polkadot/functional/0001-parachains-pvf-kagome-minority.toml
Outdated
Show resolved
Hide resolved
| name = "two" | ||
| command = "kagome" | ||
| prometheus_prefix = "kagome" | ||
| args = [ "--two", "--wasm-execution Compiled", "-lparachain=debug", "-lruntime=debug", "-lreq_chunk_protocol=trace"] |
There was a problem hiding this comment.
The '--wasm-execution' argument here is missing an equals sign; aligning it with '--wasm-execution=Compiled' (as used in the 0003 file) would improve consistency.
Suggested change
| args = [ "--two", "--wasm-execution Compiled", "-lparachain=debug", "-lruntime=debug", "-lreq_chunk_protocol=trace"] | |
| args = [ "--two", "--wasm-execution=Compiled", "-lparachain=debug", "-lruntime=debug", "-lreq_chunk_protocol=trace"] |
ErakhtinB
approved these changes
Apr 21, 2025
…ity.toml Co-authored-by: Copilot <[email protected]>
zerg-su
requested changes
May 12, 2025
| { name: "0001 PVF preparation & execution time", test: "test-polkadot-functional-0001-parachains-pvf" }, | ||
| { name: "0001 PVF preparation & execution time with KAGOME minority", test: "test-polkadot-functional-0001-parachains-pvf-kagome-minority" }, | ||
| { name: "0003 BEEFY voting and finality, test MMR proofs. Assumes Rococo sessions of 1 minute", test: "test-polkadot-functional-0003-beefy-and-mmr" }, | ||
| { name: "0003 BEEFY voting and finality, test MMR proofs. Assumes Rococo sessions of 1 minute with KAGOME minority", test: "test-polkadot-functional-0003-beefy-and-mmr-kagome-minority" }, |
Contributor
There was a problem hiding this comment.
I think in this case it's better to name the test with an additional identifier, for example '0003a' instead of just '0003', so that they can be quickly distinguished by name in the UI
|
|
||
| test-polkadot-functional-0003-beefy-and-mmr: | ||
| $(call run_test, "kagome/zombienet/polkadot/functional/0003-beefy-and-mmr.zndsl") | ||
| test-polkadot-functional-0003-beefy-and-mmr-kagome-minority: |
Contributor
There was a problem hiding this comment.
Maybe in this case it would also be a good idea to specify '0003a'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
None
Description of the Change
Includes 0001 and 0003 tests with KAGOME minority nodes
Possible Drawbacks
None
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: