Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (1)
- CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
examples/pvm/pvm_example.cpp:168
- There is an inconsistency between the external function name defined ('example_function') and the name used when calling the function ('add_numbers'), which may lead to runtime errors. Consider using a consistent naming convention for external functions.
const char* external_func_name = "example_function";
kamilsa
approved these changes
Apr 4, 2025
Harrm
reviewed
Apr 11, 2025
Contributor
Harrm
left a comment
Harrm
left a comment
There was a problem hiding this comment.
I'd like to see more elaborate error processing and tests, especially given the amount of unsafe code. I think we really should add Miri test runs in qdrvm-crates, but this is beyond the scope of this PR probably.
iceseer
force-pushed
the
feature/pvm_bindings
branch
from
8c20bd8 to
74e4e52
Compare
Harrm
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.