Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the c-hash-sig crate into the kagome-crates project by adding it as a Git submodule and registering it in the build system.
Key Changes:
- Added
c-hash-sigas a Git submodule pointing to the qdrvm/c-hash-sig repository - Registered the new crate in the CMake build configuration alongside existing cryptographic crates
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/c-hash-sig | Added as a Git submodule at commit a84e9d8 |
| CMakeLists.txt | Added c-hash-sig to the list of available crates for building |
| .gitmodules | Configured the submodule reference for c-hash-sig |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…atures in CMake configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be merged after qdrvm/c-hash-sig#1