correctly respect the dock widget option

[3nids]

partial fix for #62416

When opening an attribute table at first time, it was always creating a docked one, despite the status of the settings. This PR fixes this.

[github-actions]

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit fbd4380)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This app is not notarized, run sudo xattr -d com.apple.quarantine /Applications/QGIS*.app to avoid the warning
(Built from commit fbd4380)

[qgis-bot]

The backport to release-3_44 failed:

The process '/usr/bin/git' failed with exit code 1

stderr

error: could not apply fbd43801fd8... correctly respect the dock widget option
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

stdout

Auto-merging src/app/options/qgsoptions.cpp
CONFLICT (content): Merge conflict in src/app/options/qgsoptions.cpp
Auto-merging src/app/qgsattributetabledialog.cpp
CONFLICT (content): Merge conflict in src/app/qgsattributetabledialog.cpp
Auto-merging src/app/qgsattributetabledialog.h
Auto-merging src/core/settings/qgssettingsregistrycore.cpp
CONFLICT (content): Merge conflict in src/core/settings/qgssettingsregistrycore.cpp
Auto-merging src/core/settings/qgssettingsregistrycore.h
CONFLICT (content): Merge conflict in src/core/settings/qgssettingsregistrycore.h

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_44 release-3_44
# Navigate to the new working tree
cd .worktrees/backport-release-3_44
# Create a new branch
git switch --create backport-64954-to-release-3_44
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick fbd43801fd8d970dd3b6c7bf1f080094050e609c
# Push it to GitHub
git push --set-upstream origin backport-64954-to-release-3_44
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_44

Then, create a pull request where the base branch is release-3_44 and the compare/head branch is backport-64954-to-release-3_44.

[agiudiceandrea]

@3nids , IIUC with this PR the attribute-table/attribute-table-default-docked setting is true by default, whereas, before, the qgis/dockAttributeTable setting was false by default (and both settings are now present in QGIS3.ini with opposite values).

Moreover, it seems to me such setting doesn't actually have the intended effect, since the attribute table opens docked or non docked depending on its latest status (even after closing and reopening QGIS), not on such setting.

Maybe I'm missing something?

[3nids]

@agiudiceandrea you are correct. That's how the widget helper works and this makes the setting somehow useless.

Here is a fix: #65064

But generally, I wonder if this is worth a setting, so the other approach would be to drop the setting and let the helper class reuse the last mode that was used (mode + position). No strong opinion on this.