Add "Show Full Text" option to Identify Settings by lanckmann · Pull Request #62946 · qgis/QGIS

lanckmann · 2025-08-24T22:03:16Z

Add 'Show full text' option to Identify Settings

Adds a new configurable option in the Identify Results dialog settings menu that allows to toggle between truncated text display (with "...") and full text display on multiple lines.
Added settingShowFullText boolean setting entry.
added "Show Full Text" checkbox to Identify Settings menu.
Implemented text display switching using QLabel widgets with word wrap.
Fixes #56167

github-actions · 2025-08-24T22:53:16Z

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 2a52a26)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This app is not notarized, run sudo xattr -d com.apple.quarantine /Applications/QGIS*.app to avoid the warning
(Built from commit 2a52a26)

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 070349e)

signedav · 2025-08-26T15:07:17Z

src/app/qgsidentifyresultsdialog.cpp

+        if ( showFullText )
+        {
+          // Create a multi-line label widget to show full text
+          QLabel *valueLabel = new QLabel( representedValue );
+          valueLabel->setWordWrap( true );
+          valueLabel->setAlignment( Qt::AlignTop | Qt::AlignLeft );
+          valueLabel->setTextInteractionFlags( Qt::TextSelectableByMouse );
+          valueLabel->setStyleSheet( QStringLiteral( "QLabel { background: transparent; }" ) );
+
+          attrItem->setData( 1, Qt::DisplayRole, QString() );
+          QTreeWidget *tw = attrItem->treeWidget();
+          tw->setItemWidget( attrItem, 1, valueLabel );
+        }
+        else
+        {
+          attrItem->setData( 1, Qt::DisplayRole, representedValue );
+          QTreeWidget *tw = attrItem->treeWidget();
+          tw->setItemWidget( attrItem, 1, nullptr );
+        }


Suggested change

if ( showFullText )

{

// Create a multi-line label widget to show full text

QLabel *valueLabel = new QLabel( representedValue );

valueLabel->setWordWrap( true );

valueLabel->setAlignment( Qt::AlignTop | Qt::AlignLeft );

valueLabel->setTextInteractionFlags( Qt::TextSelectableByMouse );

valueLabel->setStyleSheet( QStringLiteral( "QLabel { background: transparent; }" ) );

attrItem->setData( 1, Qt::DisplayRole, QString() );

QTreeWidget *tw = attrItem->treeWidget();

tw->setItemWidget( attrItem, 1, valueLabel );

}

else

{

attrItem->setData( 1, Qt::DisplayRole, representedValue );

QTreeWidget *tw = attrItem->treeWidget();

tw->setItemWidget( attrItem, 1, nullptr );

}

// Create a multi-line label widget to show full text

QLabel *valueLabel = new QLabel( representedValue );

valueLabel->setAlignment( Qt::AlignTop | Qt::AlignLeft );

valueLabel->setTextInteractionFlags( Qt::TextSelectableByMouse );

valueLabel->setStyleSheet( QStringLiteral( "QLabel { background: transparent; }" ) );

if ( showFullText )

{

valueLabel->setWordWrap( true );

}

attrItem->setData( 1, Qt::DisplayRole, QString() );

QTreeWidget *tw = attrItem->treeWidget();

tw->setItemWidget( attrItem, 1, valueLabel );

Would it work like this as well? Or would it not set the ellipsis in the right way?

signedav · 2025-08-26T15:10:09Z

src/app/qgsidentifyresultsdialog.cpp

+      QLabel *valueLabel = new QLabel( fullText );
+      valueLabel->setWordWrap( true );
+      valueLabel->setAlignment( Qt::AlignTop | Qt::AlignLeft );
+      valueLabel->setTextInteractionFlags( Qt::TextSelectableByMouse );
+      valueLabel->setStyleSheet( QStringLiteral( "QLabel { background: transparent; }" ) );
+
+
+      item->setData( 1, Qt::DisplayRole, QString() );


A little bit duplicated code. If someone changes something in the styling (like background) it has to be done here and on QgsIdentifyResultsDialog. Maybe this can be improved. What do you think?

nyalldawson · 2025-10-01T00:25:18Z

src/app/qgsidentifyresultsdialog.cpp

+        // Always create a label widget for consistent styling and text selection
+        QLabel *valueLabel = createStyledLabel( representedValue, showFullText );
+        attrItem->setText( 1, representedValue ); 
        attrItem->setData( 1, Qt::DisplayRole, representedValue );


in the foundLinks == true branch we set the DisplayRole to QString() -- I believe that should also be done here, otherwise the transparent background for the label will result in overlapping text

nyalldawson · 2025-10-01T00:27:45Z

src/app/qgsidentifyresultsdialog.cpp

  layItem->setText( 0, QStringLiteral( "%1 %2" ).arg( vlayer->name(), countSuffix ) );
+
+
+  updateTextDisplay();


This shouldn't be called here -- this method will be called many times if multiple features are identified, and it's iterating through everything in the list for every feature added. That'll add up quickly.

signedav

Hi @lanckmann

It's a nice option, but there are some parts I don't get why it's done like it's done (see comments).

The label works not like expected btw. on my system (I don't have the resources to evaluate the reason atm):

signedav · 2025-11-18T11:51:14Z

src/app/qgsidentifyresultsdialog.cpp

+  }
+}
+
+QLabel *QgsIdentifyResultsDialog::createStyledLabel( const QString &text, bool wordWrap )


is there a case where createStyledLabel should not wordWrap?

I thought I might need two different label styles like the first with word wrap for long text and the second without word wrap for short text or other use cases. So i added the "wordWrap" parameter thinking it would make the function more flexible.

src/app/qgsidentifyresultsdialog.cpp

signedav · 2025-11-18T11:56:57Z

src/app/qgsidentifyresultsdialog.cpp

+                                          : item->text( 1 );
+
+  QTreeWidget *treeWidget = item->treeWidget();
+  const int lengthThreshold = 100; // Characters


This is confusing. Why 100? 100 is usually truncated...
It should be the width of the panel. Means if it's truncated, then it makes sense to wrap, no?

Or why not wrap it always when this setting is set?

I wanted to avoid creating QLabel widgets for short text like "abc" or "123", thinking it would be overhead. So I added a 100 char threshold (width calcul) .

signedav · 2025-11-18T11:57:57Z

src/app/qgsidentifyresultsdialog.cpp

+    const QFontMetrics fm( valueLabel->font() );
+    const int avgCharWidth = fm.averageCharWidth();
+    const int maxCharsPerLine = 100; // Reasonable column width estimate
+    const int maxLines = 20;


What happens, when it's more?

I was worried about performance issues with very long text values. In some datasets, attribute fields can contain huge amounts of text

src/app/qgsidentifyresultsdialog.cpp

signedav · 2025-11-24T10:15:55Z

Ok, but I'm quite busy at the moment. I'll need some time for another review.

- Ensure setText() is called before setItemWidget() to preserve item text - Fix TestQgsIdentify::closestPoint() expecting col1Item->text(1) to return value - Maintain backward compatibility with existing test expectations

…isplayRole to QString() to prevent text overlap with transparent label backgrounds- Move updateTextDisplay() call from addFeature() to updateViewModes() to avoid repeated iterations when multiple features are identified. reviewer feedback

github-actions · 2025-12-12T03:03:47Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

signedav · 2025-12-12T06:51:01Z

No stale. But not sure if I find time to review before Christmas. Sorry, about that. There are quite some pieces I need to reproduce to fully be able to confirm.

github-actions · 2026-01-02T03:08:06Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

jfbourdon · 2026-01-07T16:42:23Z

Not stale

github-actions · 2026-01-22T03:12:36Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

lanckmann · 2026-01-22T03:55:21Z

No stale

src/app/qgsidentifyresultsdialog.cpp

github-actions bot added this to the 4.0.0 milestone Aug 24, 2025

signedav reviewed Aug 26, 2025

View reviewed changes

nyalldawson requested changes Oct 1, 2025

View reviewed changes

lanckmann requested a review from nyalldawson October 10, 2025 13:43

lanckmann force-pushed the feature-identify-show-full-text-56167 branch from c92b6f9 to adae752 Compare November 3, 2025 14:23

lanckmann force-pushed the feature-identify-show-full-text-56167 branch from 14e969b to d38177e Compare November 17, 2025 15:59

lanckmann requested a review from signedav November 17, 2025 16:01

signedav reviewed Nov 18, 2025

View reviewed changes

lanckmann requested a review from signedav November 20, 2025 17:00

lanckmann added 19 commits November 27, 2025 10:20

Add 'Show full text' option to Identify SettingsImplements qgis#56167

4995a2a

Refactor label creation to reduce code duplication (reviewer)

91b0807

Fix identify results dialog text display for feature attributes

fa609a8

Fix Identify dialog Show Full Text inconsistencies

4db45c0

Fix identify dialog test failure by preserving tree item text

11ff497

- Ensure setText() is called before setItemWidget() to preserve item text - Fix TestQgsIdentify::closestPoint() expecting col1Item->text(1) to return value - Maintain backward compatibility with existing test expectations

Fix identify dialog test failure by preserving tree item text

341a7af

- Ensure setText() is called before setItemWidget() to preserve item text - Fix TestQgsIdentify::closestPoint() expecting col1Item->text(1) to return value - Maintain backward compatibility with existing test expectations

Trigger CI rebuild

447e432

Trigger CI rebuild

45ce02c

Wrap only for path values, keep item text, preserve right-click

5eebcfd

Fix duplicate text display

815ce5f

Fix Qt6 compatibility: use QTimer::singleShot for delayed layout

00846a0

Apply clang-format fixes

5aa2af9

Apply clang-format fixes

53f8809

Add missing QTextBlock header

c46b45e

Fix Display Multi-Line feature issues in identify results

3710d35

Fix identify dialog multi-line handling

5cfb90c

Address reviewer feedback

bbfde63

Trigger CI rebuild

eb90a50

lanckmann force-pushed the feature-identify-show-full-text-56167 branch from 93949b9 to eb90a50 Compare November 27, 2025 15:20

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 12, 2025

github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 12, 2025

fix ui

8185c41

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 2, 2026

github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 7, 2026

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 22, 2026

github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 22, 2026

signedav reviewed Jan 26, 2026

View reviewed changes

src/app/qgsidentifyresultsdialog.cpp Outdated Show resolved Hide resolved

src/app/qgsidentifyresultsdialog.cpp Outdated Show resolved Hide resolved

nyalldawson added the Freeze Exempt Feature Freeze exemption granted label Jan 27, 2026

fix label alignment and remove hard text truncation

aff06b9

github-actions bot added the GUI/UX Related to QGIS application GUI or User Experience label Feb 8, 2026

Merge branch 'master' into feature-identify-show-full-text-56167

0c0a246

nyalldawson added Frozen Feature freeze - Do not merge! and removed Freeze Exempt Feature Freeze exemption granted labels Feb 20, 2026

lanckmann added 2 commits March 9, 2026 00:13

code_fixup

add1777

Fix code_fixup

2a52a26

nyalldawson removed the Frozen Feature freeze - Do not merge! label Mar 10, 2026

lanckmann requested a review from signedav March 10, 2026 18:24

		layItem->setText( 0, QStringLiteral( "%1 %2" ).arg( vlayer->name(), countSuffix ) );


		updateTextDisplay();

Uh oh!

Conversation

lanckmann commented Aug 24, 2025