Skip to content

[modeler] Allow QGIS interaction while running an algorithm in the modeler#62961

Open
ValentinBuira wants to merge 16 commits intoqgis:masterfrom
ValentinBuira:true-modal-alg-dialog-modeler
Open

[modeler] Allow QGIS interaction while running an algorithm in the modeler#62961
ValentinBuira wants to merge 16 commits intoqgis:masterfrom
ValentinBuira:true-modal-alg-dialog-modeler

Conversation

@ValentinBuira
Copy link
Contributor

@ValentinBuira ValentinBuira commented Aug 26, 2025

Description

This PR allow using QGIS while running an algorithm in the modeler

exemple.running.non.modal.webm

This work by :

  • Allowing the execution algorithm dialog to be modal in a similar fashion to the execution from the toolbox
  • Except only one algorithm execution dialog is allowed per model at the time. if the user hit run and a dialog is already existing it would recreate one
  • If The dialog is already running, and only in this case, the user is prompted with a choice(see message box below) where :
    • Cancel -> do nothing and close with message box
    • Re Run algorithm -> cancel the existing dialog and recreate one
    • Show algorithm -> display the currently running algorithm
image

As the side effect this:

Screenshot From 2025-08-26 10-57-10

Funded by the QGIS user group Switzerland

 - Allow QGIS interaction while running
 - Only one algorithm execution dialog is allowed per model
 - The dialog check if there has been any change to the model

* Fix RuntimeError: wrapper C/C++ object of type AlgorithmDialog has been deleted
* text dialog
* doc tag
@github-actions github-actions bot added this to the 4.0.0 milestone Aug 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2025

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 7b8dbfb)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This app is not notarized, run sudo xattr -d com.apple.quarantine /Applications/QGIS*.app to avoid the warning
(Built from commit 7b8dbfb)

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit da24980)

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 10, 2025
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 15, 2025
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 30, 2025
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 1, 2025
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 29, 2025
@github-actions github-actions bot closed this Nov 6, 2025
@3nids 3nids reopened this Dec 2, 2025
@qgis qgis deleted a comment from github-actions bot Dec 2, 2025
@qgis qgis deleted a comment from github-actions bot Dec 2, 2025
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 2, 2025
@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 17, 2026
@github-actions github-actions bot closed this Jan 24, 2026
@3nids 3nids reopened this Jan 26, 2026
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 26, 2026
@qgis qgis deleted a comment from github-actions bot Jan 26, 2026
@qgis qgis deleted a comment from github-actions bot Jan 26, 2026
@qgis qgis deleted a comment from github-actions bot Jan 26, 2026
@qgis qgis deleted a comment from github-actions bot Jan 26, 2026
@github-actions github-actions bot added the Processing Relating to QGIS Processing framework or individual Processing algorithms label Jan 27, 2026
@nyalldawson nyalldawson added the Freeze Exempt Feature Freeze exemption granted label Jan 27, 2026
@ValentinBuira ValentinBuira force-pushed the true-modal-alg-dialog-modeler branch from 69a43aa to aa458b9 Compare January 29, 2026 00:33
@ValentinBuira
Copy link
Contributor Author

I completely rework the PR to account for running a subset and as well make it way simpler in design.

Instead of a complicated watch if the model have changed, the dialog is re created each time.

If an algorithm is already running and only in this case, the user is asked
Cancel -> do nothing and close with message box
Re Run algorithm -> cancel the existing dialog and recreate one
Show algorithm -> display the currently running algorithm

image

I updated the PR description to reflect the latest changes.

*
* \since QGIS 4.0
*/
virtual bool isRunning();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain in the docs the difference with isFinalized() (and potentially link them in the docs)

@nyalldawson nyalldawson added Frozen Feature freeze - Do not merge! and removed Freeze Exempt Feature Freeze exemption granted labels Feb 20, 2026
@nyalldawson nyalldawson removed the Frozen Feature freeze - Do not merge! label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Processing Relating to QGIS Processing framework or individual Processing algorithms

Projects

None yet

3 participants