Fix PDF theme export#63580

Open

troopa81 wants to merge 2 commits intoqgis:masterfrom

troopa81:fix_pdf_export_themes

Contributor

troopa81 commented Oct 16, 2025 •

edited

Loading

Include group name in layerId key when mapping from layerId to tree node.

If not, same layer would be mapped to only one and only group if this layer is included in different groups (with themes for instance).

Fixes #62014

troopa81 added Bug backport queued_ltr_backports backport release-3_44 labels

github-actions bot added this to the 4.0.0 milestone

Contributor

github-actions bot commented Oct 16, 2025 •

edited

Loading

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 7ba875e)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This app is not notarized, run sudo xattr -d com.apple.quarantine /Applications/QGIS*.app to avoid the warning
(Built from commit 7ba875e)

Member

agiudiceandrea commented Oct 16, 2025 •

edited

Loading

Does this fix #62014? Does this also fix #63475?

baswein mentioned this pull request

Render Layers as a Group not working with Themes in Layout #50391

Open

2 tasks

Contributor Author

troopa81 commented Oct 17, 2025

Does this fix #62014?

Yes, It's referenced in the commit. I've added it to the PR.

Does this also fix #63475?

I don't think so, but I'm not sure. It's worth testing

Member

agiudiceandrea commented Oct 19, 2025

Does this also fix #63475?

I don't think so, but I'm not sure. It's worth testing

Unfortunately, it doesn't fix #63475.

Member

nicogodet commented Oct 21, 2025 •

edited

Loading

@troopa81 We tested the Qt6 build and we found something stranged. The bug is not fixed using real data. Unfortunately, I can't share the data.
Can you provide an email to share a DL link if you are willing to investigate further more ?

Contributor Author

troopa81 commented Oct 28, 2025 •

edited

Loading

Can you provide an email to share a DL link if you are willing to investigate further more ?

sure! julien dot cabieces at oslandia dot com

Contributor Author

troopa81 commented Nov 4, 2025

After looking into @nicogodet data, there is (are?) other issues, but I propose to move forward with this PR which actually fix the referenced issue.

nicogodet approved these changes

View reviewed changes

Contributor

github-actions bot commented Nov 19, 2025

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions bot added the stale label

Contributor

github-actions bot commented Nov 26, 2025

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

github-actions bot closed this

nicogodet reopened this

github-actions bot removed the stale label

Contributor

github-actions bot commented Dec 11, 2025

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions bot added the stale label

troopa81 removed the stale label

Contributor

github-actions bot commented Jan 1, 2026

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions bot added the stale label

troopa81 removed the stale label

Contributor

github-actions bot commented Jan 20, 2026

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions bot added the stale label

troopa81 removed the stale label

troopa81 mentioned this pull request

Geospatial PDF: Add option to follow the QGIS layer tree configuration (groups, order, names, visibility, grouplayers) #64684

Open

Contributor

github-actions bot commented Feb 6, 2026

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

github-actions bot added the stale label

Contributor

github-actions bot commented Feb 13, 2026

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

github-actions bot closed this

troopa81 removed the stale label

troopa81 reopened this

troopa81 force-pushed the fix_pdf_export_themes branch 2 times, most recently from 587d946 to 298ae7e Compare

February 18, 2026 10:07

Contributor Author

troopa81 commented Feb 18, 2026

@nyalldawson @agiudiceandrea Do you mind reviewing this long standing PR? I would like to continue fixing error in this area of the code.

troopa81 force-pushed the fix_pdf_export_themes branch from 298ae7e to 295dbd4 Compare

February 18, 2026 10:14

troopa81 added 2 commits

February 18, 2026 12:13


          fix(PDFExport): Fix themes export

295dbd4

Include group name in layerId key when mapping from layerId to tree
node. If not, same layer would be mapped to only one and only group if
this layer is included in different groups (with themes for instance).

Fix qgis#62014


          fix(GeoPdfExport): Fix mix of grouped and global layers

7ba875e

This was referenced Feb 19, 2026

[GeoPdfExport] Avoid map theme contaminate non-map-them items #65008

Merged

[GeoPdfExport] Use layer order for group layer children #64983

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport queued_ltr_backports backport release-3_44 Bug