[fix] Elevation profiles: store weak map layer refs instead of raw layer pointers when setting profile sources#64813
Open
gacarrillor wants to merge 3 commits intoqgis:masterfrom
Open
Conversation
…(e.g., a layer from the project), subsequent usage of sources does not crash (i.e., there are no dangling pointers, but nullptrs that we can discard)
…refs instead of raw layer pointers when saving profile sources
…_qgslayoutelevationprofile.py, since setLayers() should be removed in QGIS 5.0, as it doesn't account for custom profile sources (which may come from plugins)
github-actions
bot
added
Print Layouts
gacarrillor
added
Bug
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #64218