[MapToolCapture] When undoing, remove whole curve only when it has more than 2 vertices#65027
Open
JuhoErvasti wants to merge 1 commit intoqgis:masterfrom
Open
[MapToolCapture] When undoing, remove whole curve only when it has more than 2 vertices#65027JuhoErvasti wants to merge 1 commit intoqgis:masterfrom
JuhoErvasti wants to merge 1 commit intoqgis:masterfrom
Conversation
github-actions
bot
added
the
Digitizing
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
JuhoErvasti
force-pushed
the
fix-58813
branch
from
0d03479 to
5ba0953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58813.
With #51943, if the layer has a different CRS than the project, if you're digitizing with a curve the curve will get transformed into a line with interpolated vertices, which is why when undoing the entire curve gets deleted in case of different CRS's. However, when undoing digitized straight segments this causes the bug described in the issue.
Fix the bug by deleting the entire last curve only if actually contains a transformed curve (has more than 2 vertexes).