Fixed sytle selector on root layer in LayerTree#567
Closed
NullSeile wants to merge 1 commit intoqgis:masterfrom
Closed
Fixed sytle selector on root layer in LayerTree#567NullSeile wants to merge 1 commit intoqgis:masterfrom
NullSeile wants to merge 1 commit intoqgis:masterfrom
Conversation
manisandro
reviewed
Feb 17, 2026
| }; | ||
| getLayerStyles = (layer) => { | ||
| return layer?.sublayers?.reduce((styleList, sublayer) => { | ||
| Object.assign(styleList, this.getLayerStyles(sublayer.sublayers)); |
Member
There was a problem hiding this comment.
A fix could be to just pass sublayer instead of sublayer.sublayers here?
Contributor
Author
There was a problem hiding this comment.
Yes, but we would loose any style information that the root layer has. I'm not sure if it can have any, but did it like this just to be sure.
Member
There was a problem hiding this comment.
In theory it cannot have any - the WMS root layer is not represented in the QGIS layer tree, and does indeed not correspond to a QGIS Project layer.
Member
|
I've addressed this in a584cb7 - thanks for reporting! |
Contributor
Author
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The style selector in the root layer had a bug in the recursive algorithm which made it not work. This pull request should fix it.