remove parser by Edoardo-Pedicillo · Pull Request #92 · qiboteam/boostvqe

Edoardo-Pedicillo · 2024-10-16T05:37:18Z

#84 (comment)

andrea-pasquale

Thanks @Edoardo-Pedicillo, just a few minor changes.

README.md

src/boostvqe/boost.py

README.md

src/boostvqe/boost.py

Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com>

…plify_main

marekgluza · 2024-11-05T05:02:52Z

src/boostvqe/boost.py

+            Learning rate decay factor used when the optimizer is SGD (stochastic gradient descent).
+
+        nboost (int, default: 1):
+            Number of times DBI (Deterministic Boost Iteration) is applied in the optimization process.


DBI = double-bracket iteration

is this part of the CMA optimizer?

I think this is the number of times DBQA is used along a single, long, VQE training.

marekgluza · 2024-11-05T05:03:34Z

src/boostvqe/boost.py


-    if args.optimizer_options is None:
-        opt_options = {}
+        dbi_steps (int, default: 1):


Suggested change

dbi_steps (int, default: 1):

dbqa_steps (int, default: 1):

this code should be capable of running DBI (dense matrices) and GCI (qibo.Circuit)

marekgluza · 2024-11-05T05:04:37Z

src/boostvqe/boost.py

+        dbi_steps (int, default: 1):
+            Number of DBI iterations performed each time DBI is called.
+
+        stepsize (float, default: 0.01):


Suggested change

stepsize (float, default: 0.01):

dbr_duration (float, default: 0.01):

Each DBI step is DBR (double-bracket rotation) and in the strategies proceeding we always say DBR duration

I think the stepsize has been removed from the arguments, but still remains in the docstrings. One of the two things should be solved.

marekgluza · 2024-11-05T05:04:50Z

src/boostvqe/boost.py

-    if args.optimizer_options is None:
-        opt_options = {}
+        dbi_steps (int, default: 1):
+            Number of DBI iterations performed each time DBI is called.


iterations of what?

Number of rotations, namely DBQA steps.

marekgluza · 2024-11-05T05:05:37Z

src/boostvqe/boost.py

+        store_h (bool, default: False):
+            If this flag is set, the Hamiltonian `H` is stored at each iteration.
+
+        hamiltonian (str, default: "XXZ"):


after merging #77 this can become also a symbolic Hamiltonian

Yes, this is also proposed by @Edoardo-Pedicillo at line 148.

marekgluza · 2024-11-05T05:07:46Z

src/boostvqe/boost.py

+
+        mode:
+            Define the DBI Generator.
+    """


Suggested change

"""

"""please_be_verbose:

Flag which switches on verbose reporting - after each DBQA step a report is printed on energy gain, fidelity and circuit depth and stored in the output_folder as a log file.

Also this should be done in a separate PR

Ok, let's move ahead without it

README.md

marekgluza · 2024-11-05T05:21:32Z

Thank you @Edoardo-Pedicillo !

I like the overall code structure and e.g. the clarity of the new Readme.

I removed Sam as reviewer:

agree with @MatteoRobbiati and @andrea-pasquale if the coding approach works for you
then merge to finish this refactoring
I'll move ahead with the journal submission if you confirm that the code can reproduce what we had in plots
the README example is very small so we should have a simple documentation script/notebook which additionally explains how to extract the energy gain and circuit depth

marekgluza · 2024-11-05T05:28:16Z

Will this close #83 where the number of trotter steps and dbqa steps should be different?

Some fixes to run VQE trainings + derivative wrt RBS parameter

src/boostvqe/boost.py

MatteoRobbiati · 2024-11-05T08:22:22Z

src/boostvqe/boost.py

+            Learning rate decay factor used when the optimizer is SGD (stochastic gradient descent).
+
+        nboost (int, default: 1):
+            Number of times DBI (Deterministic Boost Iteration) is applied in the optimization process.


I think this is the number of times DBQA is used along a single, long, VQE training.

MatteoRobbiati · 2024-11-05T08:22:59Z

src/boostvqe/boost.py

-    if args.optimizer_options is None:
-        opt_options = {}
+        dbi_steps (int, default: 1):
+            Number of DBI iterations performed each time DBI is called.


Number of rotations, namely DBQA steps.

MatteoRobbiati · 2024-11-05T08:27:52Z

src/boostvqe/boost.py

+        store_h (bool, default: False):
+            If this flag is set, the Hamiltonian `H` is stored at each iteration.
+
+        hamiltonian (str, default: "XXZ"):


Yes, this is also proposed by @Edoardo-Pedicillo at line 148.

MatteoRobbiati · 2024-11-05T08:32:01Z

src/boostvqe/boost.py

+        dbi_steps (int, default: 1):
+            Number of DBI iterations performed each time DBI is called.
+
+        stepsize (float, default: 0.01):


I think the stepsize has been removed from the arguments, but still remains in the docstrings. One of the two things should be solved.

Co-authored-by: Matteo Robbiati <62071516+MatteoRobbiati@users.noreply.github.com>

remove parser

52c6bcd

Edoardo-Pedicillo mentioned this pull request Oct 16, 2024

Close PR #77 to run shots with GCI and not DBI for J1-J2 #88

Open

expose DBI type

401d1aa

Edoardo-Pedicillo mentioned this pull request Oct 16, 2024

main.py runs only in single commutator mode - there is no GCI on main branch right now #84

Closed

1 task

Edoardo-Pedicillo added 3 commits October 16, 2024 10:32

use nlayers

3290e09

move main.py in src/boostvqe/boost.py and update the README

94c1420

typo in README

8bd5c91

Edoardo-Pedicillo marked this pull request as ready for review October 16, 2024 06:49

Edoardo-Pedicillo requested review from MatteoRobbiati and andrea-pasquale October 16, 2024 06:49

Edoardo-Pedicillo added 4 commits October 16, 2024 10:50

clean code

8ea85f0

README installation instructions

4ab779c

README installation instructions

ed50b14

update pyproject

5744c7a

andrea-pasquale approved these changes Oct 16, 2024

View reviewed changes

Edoardo-Pedicillo and others added 5 commits October 16, 2024 12:09

remove help from the README script

9c54a48

rename main function dbi_vqe

e9b12b1

remove -e option in README

f70b447

increase example readibility

18f97dd

Update src/boostvqe/boost.py

79cf18b

Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com>

Edoardo-Pedicillo mentioned this pull request Oct 16, 2024

Loading VQE should be singled out as a separate script #85

Open

6 tasks

Edoardo-Pedicillo requested a review from Sam-XiaoyueLi October 18, 2024 05:29

Edoardo-Pedicillo added 2 commits October 22, 2024 17:18

fix: remove optimize_dbi_step

c581583

Merge branch 'simplify_main' of github.com:qiboteam/boostvqe into sim…

102b2ab

…plify_main

marekgluza linked an issue Nov 5, 2024 that may be closed by this pull request

main.py runs only in single commutator mode - there is no GCI on main branch right now #84

Closed

1 task

marekgluza reviewed Nov 5, 2024

View reviewed changes

README.md Show resolved Hide resolved

marekgluza removed the request for review from Sam-XiaoyueLi November 5, 2024 05:18

marekgluza mentioned this pull request Nov 5, 2024

Provide intuitive documentation how to run the code #97

Open

This was referenced Nov 5, 2024

DBI steps vs Trotter steps #81

Open

XXZ_EvolutionOracle not passing arguments #68

Closed

DBI class 3rd order GC and reduced 3rd math error #67

Open

System size scaling #98

Open

MatteoRobbiati and others added 4 commits November 5, 2024 12:28

feat: some fixes to Edo's improvments

8c0db95

feat: add script to run vqe training

c168558

fix: RBS derivative

ad3f398

Merge pull request #99 from qiboteam/training_fixes

7e1c1db

Some fixes to run VQE trainings + derivative wrt RBS parameter

MatteoRobbiati reviewed Nov 12, 2024

View reviewed changes

Edoardo-Pedicillo and others added 7 commits November 12, 2024 21:33

Update src/boostvqe/boost.py

981f103

Co-authored-by: Matteo Robbiati <62071516+MatteoRobbiati@users.noreply.github.com>

refactor: use time_steps

e35f336

refactor: rename dbi_steps in dbqa_steps

52339e5

refactor: rename time)steps in dbr_duration

aee638a

docs: change dbqa_steps description

33050cb

fix: boost.py working

5301e45

Merge branch 'main' into simplify_main

e122902

Edoardo-Pedicillo merged commit 3232c74 into main Dec 16, 2024

Edoardo-Pedicillo deleted the simplify_main branch December 16, 2024 07:16

	stepsize (float, default: 0.01):
	dbr_duration (float, default: 0.01):

	"""
	"""please_be_verbose:
	Flag which switches on verbose reporting - after each DBQA step a report is printed on energy gain, fidelity and circuit depth and stored in the output_folder as a log file.

Conversation

Edoardo-Pedicillo commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrea-pasquale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marekgluza commented Nov 5, 2024

Uh oh!

marekgluza commented Nov 5, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Edoardo-Pedicillo commented Oct 16, 2024 •

edited

Loading