Skip to content

don't cache qblox.cluster.Cluster._modules#1355

Merged
RoyStegeman merged 1 commit intomainfrom
hotfix_rs
Jan 14, 2026
Merged

don't cache qblox.cluster.Cluster._modules#1355
RoyStegeman merged 1 commit intomainfrom
hotfix_rs

Conversation

@RoyStegeman
Copy link
Member

@RoyStegeman RoyStegeman commented Jan 14, 2026

In an RB experiment the cluster is connected and disconnected multiple times. By caching we try to interact with modules that have been disconnected.

Tested that it now works.

In an RB experiment the cluster is connected and disconnected multiple times. By caching we try to interact with modules that have been disconnected.
@RoyStegeman RoyStegeman added the bug Something isn't working label Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 40.08%. Comparing base (e6f498b) to head (84fa01f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/qibolab/_core/instruments/qblox/cluster.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1355   +/-   ##
=======================================
  Coverage   40.08%   40.08%           
=======================================
  Files         114      114           
  Lines        5596     5596           
=======================================
  Hits         2243     2243           
  Misses       3353     3353           
Flag Coverage Δ
unittests 40.08% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RoyStegeman RoyStegeman merged commit d3bc9a7 into main Jan 14, 2026
64 of 65 checks passed
@RoyStegeman RoyStegeman deleted the hotfix_rs branch January 14, 2026 13:26
@alecandido alecandido linked an issue Jan 16, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RB not working if unrolling is not done

2 participants