Align Qblox attenuation with parameters convention#1370
Merged
alecandido merged 1 commit intomainfrom Jan 27, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1370 +/- ##
=======================================
Coverage 39.44% 39.44%
=======================================
Files 114 114
Lines 5697 5697
=======================================
Hits 2247 2247
Misses 3450 3450
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RoyStegeman
approved these changes
Jan 23, 2026
alecandido
force-pushed
the
qblox-lo-att
branch
from
7f44157 to
a11a92e
Compare
|
|
||
| def att_(self, lo: OscillatorConfig) -> None: | ||
| self.att = int(lo.power) | ||
| self.att = -int(lo.power) |
There was a problem hiding this comment.
great! we just need to propagate this to the platforms using qblox.
jevillegasdatTII
approved these changes
Jan 26, 2026
alecandido
force-pushed
the
qblox-lo-att
branch
from
a11a92e to
91db3dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original purpose of calling it
.powerwas to also allow amplification.Despite amplification not being available in Qblox, we should preserve the meaning of the configuration value, to make it consistent with other instruments (especially for the sake of exposing a uniform interface to Qibocal and similar projects).