in qblox: mixer correction per sequencer#1371
Merged
RoyStegeman merged 4 commits intomainfrom Jan 23, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
- Coverage 39.42% 39.26% -0.17%
==========================================
Files 114 115 +1
Lines 5694 5718 +24
==========================================
Hits 2245 2245
- Misses 3449 3473 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RoyStegeman
force-pushed
the
qbloxiqmixerconfig
branch
from
abf3a59 to
eb26459
Compare
RoyStegeman
force-pushed
the
qbloxiqmixerconfig
branch
from
e1dfc8e to
00c7df7
Compare
RoyStegeman
force-pushed
the
qbloxiqmixerconfig
branch
from
ed75a9d to
c094238
Compare
alecandido
reviewed
Jan 23, 2026
Comment on lines
+14
to
+19
| """qblox has 6 sequencers per module. | ||
| scale_q_*: The relative amplitude scale/factor of the q channel, to account for I-Q | ||
| amplitude imbalance. | ||
| phase_q_*: The phase offset of the q channel, to account for I-Q phase | ||
| imbalance. | ||
| """ |
Member
There was a problem hiding this comment.
Maybe put this as the class docstring. It will be part of the public API, so it is not bad that gets printed in the Sphinx generated docs :)
alecandido
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been reverted in #1374
Before this PR mixer calibration settings were configurable per port. Whileoffset_iandoffset_qare indeed port-level corrections, this is not the case forscale_qandphase_qwhich are at the sequencer-level. In qblox the sequencers are separate from ports or qubits.This PR introduces theQbloxIqMixerConfigclass which holds the scale and phase parameters for each sequencer.Important
The motivation to unravel all the sequencer numbers to a single configuration, as opposed to spread these over the channel-related configs, is that the mixer calibration parameters are related to the physical sequencer objects, since they are related to analogue electronics behavior.Instead, the channels have no stable assignment to the sequencers, which are considered to be just digital processors, and thus all equivalent (and they mostly are, other than the physical signal routing to the mixer).And this is the reason why we want this configurations to be mapped to the actual physical object, the mixer (and not the channels, which are more "logical").