Skip to content

Commit 00cd776

Browse files
author
YangSen-qn
committed
chunk size set min size
1 parent e573125 commit 00cd776

File tree

2 files changed

+23
-11
lines changed

2 files changed

+23
-11
lines changed

library/src/androidTest/java/com/qiniu/android/ComplexUploadSceneTest.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,17 @@ public void testMutiUploadV1(){
3030
param.completeCount = 0;
3131
param.successCount = 0;
3232

33-
final int start = 30;
33+
final int start = 35;
3434
for (int i = start; i < maxCount; i++) {
3535
Configuration config = new Configuration.Builder()
3636
.resumeUploadVersion(Configuration.RESUME_UPLOAD_VERSION_V1)
3737
.useConcurrentResumeUpload(true)
3838
.concurrentTaskCount(3)
39-
.chunkSize(i%4 * 1024 * 1024 + i)
39+
.chunkSize((i%4 + 1) * 1024 * 1024 + i)
4040
.build();
4141

4242
int size = (i + 1) * 1024;
43-
String keyUp = "complex_upload_v1_" + size + "k";
43+
final String keyUp = "android_complex_upload_v1_" + size + "k";
4444
File file = null;
4545
try {
4646
file = TempFile.createFile(size);
@@ -60,6 +60,7 @@ public void complete(String key, ResponseInfo info, JSONObject response) {
6060
signal.countDown();
6161
}
6262
}
63+
Log.d("upload key:" + keyUp, "complex_upload_v1 response: " + info);
6364
}
6465
});
6566
}
@@ -81,17 +82,17 @@ public void testMutiUploadV2(){
8182
param.completeCount = 0;
8283
param.successCount = 0;
8384

84-
final int start = 30;
85+
final int start = 35;
8586
for (int i = start; i < maxCount; i++) {
8687
Configuration config = new Configuration.Builder()
8788
.resumeUploadVersion(Configuration.RESUME_UPLOAD_VERSION_V2)
8889
.useConcurrentResumeUpload(true)
8990
.concurrentTaskCount(3)
90-
.chunkSize(i%4 * 1024 * 1024 + i)
91+
.chunkSize((i%4 + 1) * 1024 * 1024 + i)
9192
.build();
9293

9394
int size = (i + 1) * 1024;
94-
String keyUp = "complex_upload_v2_" + size + "k";
95+
final String keyUp = "android_complex_upload_v2_" + size + "k";
9596
File file = null;
9697
try {
9798
file = TempFile.createFile(size);
@@ -104,13 +105,14 @@ public void testMutiUploadV2(){
104105
public void complete(String key, ResponseInfo info, JSONObject response) {
105106
synchronized (param){
106107
param.completeCount += 1;
107-
if (info != null && info.isOK()){
108+
if (info != null && (info.isOK() || info.statusCode == 614)){
108109
param.successCount += 1;
109110
}
110111
if (param.completeCount == (maxCount - start)){
111112
signal.countDown();
112113
}
113114
}
115+
Log.d("upload key:" + keyUp, "complex_upload_v2 response: " + info);
114116
}
115117
});
116118
}

library/src/main/java/com/qiniu/android/storage/Configuration.java

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,21 @@ public final class Configuration {
110110

111111

112112
private Configuration(Builder builder) {
113+
useConcurrentResumeUpload = builder.useConcurrentResumeUpload;
114+
resumeUploadVersion = builder.resumeUploadVersion;
115+
concurrentTaskCount = builder.concurrentTaskCount;
116+
117+
if (builder.resumeUploadVersion == RESUME_UPLOAD_VERSION_V1) {
118+
if (builder.chunkSize < 1024) {
119+
builder.chunkSize = 1024;
120+
}
121+
} else if (builder.resumeUploadVersion == RESUME_UPLOAD_VERSION_V2) {
122+
if (builder.chunkSize < 1024 * 1024) {
123+
builder.chunkSize = 1024 * 1024;
124+
}
125+
}
113126
chunkSize = builder.chunkSize;
127+
114128
putThreshold = builder.putThreshold;
115129

116130
connectTimeout = builder.connectTimeout;
@@ -130,10 +144,6 @@ private Configuration(Builder builder) {
130144

131145
useHttps = builder.useHttps;
132146

133-
useConcurrentResumeUpload = builder.useConcurrentResumeUpload;
134-
resumeUploadVersion = builder.resumeUploadVersion;
135-
concurrentTaskCount = builder.concurrentTaskCount;
136-
137147
zone = builder.zone != null ? builder.zone : new AutoZone();
138148
}
139149

0 commit comments

Comments
 (0)