add cross-atac to snare norebook #7
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the diffusion based atac imputation we talked about to the snare test notebook. I left the knn-based approach in there as a comparison. Since it also uses the neighborhood in RNA-expression space, the results are somewhat similar. In both cases, however, the regularization is quite strong (300 neighbors for the knn and 10 iterations for the diffusion based). It seems the 300 might have been chosen since it works well in the gene based correlations and I tried to produce comparable results with my 10 iterations.
@qinqian Please let me know if there is anything else I can do and thank you for all the organization and preparation!