Merged
Conversation
Collaborator
Eric-Arellano
left a comment
There was a problem hiding this comment.
Excellent!
Btw, I recommed simplifying the file organization to not use a folder per file, given how simple our project is. You should be able to move, for example, src/anchors/mod.rs to be src/anchors.rs.
src/anchors/mod.rs
Outdated
| for line in markdown.split("\n") { | ||
| if let Some(heading) = get_first_capture(line, &heading_regex) { | ||
| let anchor = heading_to_anchor(heading); | ||
| /// Given any markdown node, extract the |
Comment on lines
-47
to
-51
| if let Some(children) = node.children() { | ||
| for child in children { | ||
| extract_from_node(child, links); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Why is this part removed?
Collaborator
Author
There was a problem hiding this comment.
It's moved to
mdx-link-extract/src/mdx/mod.rs
Lines 25 to 34 in 38c2c67
Before, extract_from_node was the only function that used the AST, so it walked it too. Now we walk it in walk_ast.
Eric-Arellano
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11 and fixes #12
mdx::walk_astfunction calls thelinks::extract_from_nodefor each AST node.textandinlinecodenodes. For ids, we look for theidprop.The rest of the commits are minor changes (renaming / formatting / etc.)
I ran this new code against Qiskit/documentation and it (correctly) detects one broken link.