Conversation
coruscating
reviewed
Nov 1, 2023
Collaborator
coruscating
left a comment
coruscating
left a comment
There was a problem hiding this comment.
Thanks, it looks like you're missing the test and some code from the previous PR, can those be added? Without the "_completion_times": self._completion_times, I get a KeyError when trying to access completion_times for an experiment run on a simulaton. Also, this property isn't populated for experiments loaded from the database, but that might be out of the scope of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the way the
completion_timesproperty ofExperimentDatais calculated to allow for the current format used byIBMCircuitJob.Details and comments
Fixes #1205