Adopt database classes and local experiment service from qiskit-ibm-experiment#1614
Open
wshanks wants to merge 1 commit intoqiskit-community:mainfrom
Open
Adopt database classes and local experiment service from qiskit-ibm-experiment#1614wshanks wants to merge 1 commit intoqiskit-community:mainfrom
wshanks wants to merge 1 commit intoqiskit-community:mainfrom
Conversation
…xperiment
* Remove the `qiskit-ibm-experiment` dependency
+ Adopt `DbExperimentData`, `DbAnalysisResultData`, and `ResultQuality`
+ Adapt `IBMExperimentService` into `LocalExperimentService` which
only maintains the local features of the original class.
+ Remove code for inferring service from backend or provider
* Revise the experiment service howto and other comments to refer to the
`LocalExperimentService` and not to the retired cloud experiment
service.
* Add optional pyyaml dependency
* Drop IBMProvider protocol
* Update `ExperimentData` and `AnalysisResult` not to try to work with
the old IBM experiment service.
* Remove `FakeService` test class and use `LocalExperimentService` in
tests instead.
+ Additionally, remove all usage of mocking from the tests, using
`LocalExperimentService` in place of a mocked service.
wshanks
force-pushed
the
adopt-qiskit-ibm-experiment
branch
from
5fdb1f2 to
4b820d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qiskit-ibm-experimentdependencyDbExperimentData,DbAnalysisResultData, andResultQualityIBMExperimentServiceintoLocalExperimentServicewhichonly maintains the local features of the original class.
LocalExperimentServiceand not to the retired cloud experimentservice.
ExperimentDataandAnalysisResultnot to try to work withthe old IBM experiment service.
FakeServicetest class and useLocalExperimentServiceintests instead.
LocalExperimentServicein place of a mocked service.