Pasqal local - Link munge optionally and inject a couple env variables into user env#172
Pasqal local - Link munge optionally and inject a couple env variables into user env#172
Conversation
6c26770 to
6b3baa3
Compare
|
This is finally ready for review alongside the QRMI MR. @ohtanim I am happy to get your feedback on this optional linking of munge. This is the first QRMI implementation which requires linking to a C library that is not required for the other implementations. You may have an opinion on how to handle this properly in terms of documentation and/or distribution. Thank you! |
ohtanim
left a comment
There was a problem hiding this comment.
@MatthieuMoreau0 Thank you very much for your enhancement. Your changes look good to me, but I left 2 minor comments. Do you think my comments are reasonable to Pasqal ?
plugins/spank_qrmi/spank_qrmi.c
Outdated
There was a problem hiding this comment.
Could you add Pasqal copyright?
plugins/spank_qrmi/spank_qrmi.h
Outdated
There was a problem hiding this comment.
Could you please add Pasqal copyright ?
|
@ohtanim I have amended the copyright notices. FYI the QRMI MR for pasqal local support has been merged to main today: qiskit-community/qrmi@fcb281c |
|
merged. new release 0.6.0 was created. |
|
Thank you! |
Description of Change
In this MR, I made a few updates to the spank plugin so that it supports the Pasqal Local QRMI introduced in qiskit-community/qrmi#32
Linking munge
For Pasqal Local we use munge to authenticate the root and end users, see QRMI MR for details on the auth flow. In this MR, I updated the CMakeLists.txt to link munge through the
-DENABLE_MUNGE=ONoption.When the option is activated, munge is dynamically linked:
Defining env variables for slurm job ID and UID
Each task submitted to the pasqal local middleware will be mapped to a slurm job ID and a UID. The UID enables us to isolate user data, the slurm job ID will help us map QPU tasks to a slurm job ID for debugging.
These can be retrived using
spank_get_itemand are mapped to env variables prefixed byQRMIas they are intended to be consumed by the QRMIChecklist ✅
Ticket