Skip to content

[BUGFIX|PASQAL] Add return case when acquire step fails#181

Merged
awennersteen merged 1 commit intoqiskit-community:mainfrom
badtst:tb/acquire_fail_return
Mar 30, 2026
Merged

[BUGFIX|PASQAL] Add return case when acquire step fails#181
awennersteen merged 1 commit intoqiskit-community:mainfrom
badtst:tb/acquire_fail_return

Conversation

@badtst
Copy link
Copy Markdown
Contributor

@badtst badtst commented Mar 30, 2026

Description of Change

In case the acquire of the qrmi resource failed within the SPANK plugin, _acquire_qpu would not return with a NULL pointer and error was not handled correctly by calling funtion slurm_spank_init_post_opt

Checklist ✅

  • Have you included a description of this change?
  • Have you updated the relevant documentation to reflect this change?
  • Have you made sure CI is passing before requesting a review?

Ticket

  • Fixes #
  • Is Part of #

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 30, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Collaborator

@ohtanim ohtanim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks,

@ohtanim ohtanim added the bug Something isn't working label Mar 30, 2026
Copy link
Copy Markdown
Collaborator

@awennersteen awennersteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@awennersteen awennersteen merged commit 346ca3b into qiskit-community:main Mar 30, 2026
2 checks passed
@badtst badtst deleted the tb/acquire_fail_return branch March 31, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants