Skip to content

fix: don't touch packages with 'workspace' set as a package version #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: don't touch packages with 'workspace' set as a package version #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80a9321
fix: don't touch packages with 'workspace' set as a package version
bartlomiejzuber Aug 9, 2023
5b49730
fix: add parentheses
bartlomiejzuber Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/updateDeps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,8 @@ const resolveNextVersion = (currentVersion, nextVersion, strategy = "override",
// Check the next pkg version against its current references.
// If it matches (`*` matches to any, `1.1.0` matches `1.1.x`, `1.5.0` matches to `^1.0.0` and so on)
// release will not be triggered, if not `override` strategy will be applied instead.
if ((strategy === "satisfy" || strategy === "inherit") && semver.satisfies(nextVersion, currentVersion)) {
// If currentVersion has "workspace" inside it means it shouldn't be checked with semver.satisfies as it's covered by yarn's/pnpm's/npm's workspaces versioning
if (currentVersion.includes("workspace") || ((strategy === "satisfy" || strategy === "inherit") && semver.satisfies(nextVersion, currentVersion))) {
return currentVersion;
}

Expand Down