Skip to content

fix(prettier): honor .prettierignore during checks#2751

Open
davehenton wants to merge 1 commit intomainfrom
codex/honor-prettierignore
Open

fix(prettier): honor .prettierignore during checks#2751
davehenton wants to merge 1 commit intomainfrom
codex/honor-prettierignore

Conversation

@davehenton
Copy link
Copy Markdown
Member

Summary

  • run the Prettier plugin from the staged repo root so Prettier discovers .prettierignore correctly
  • include .gitignore in the plugin cache-affecting files to preserve Prettier's default ignore behavior
  • add a regression test covering an ignored file alongside a non-ignored unformatted file

Testing

  • cargo test -p qlty network_tests -- --ignored

Fixes #2499

Copy link
Copy Markdown
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@qltysh
Copy link
Copy Markdown
Contributor

qltysh bot commented Apr 11, 2026

Qlty

Coverage Impact - ubuntu-latest

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh
Copy link
Copy Markdown
Contributor

qltysh bot commented Apr 11, 2026

Qlty

Coverage Impact - macos-15

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Prettier plugin does not honor .prettierignore

1 participant