Skip to content

Check PRs for invalid keyboard build targets#25992

Merged
zvecr merged 1 commit intomasterfrom
zvecr-patch-4
Feb 18, 2026
Merged

Check PRs for invalid keyboard build targets#25992
zvecr merged 1 commit intomasterfrom
zvecr-patch-4

Conversation

@zvecr
Copy link
Member

@zvecr zvecr commented Feb 7, 2026

Description

#25991 contains a submission with a info.json and rules.mk, where this has not been an accepted keyboard build target for quite a while. As CI cannot detect any build targets on the PR, it tests nothing and marks it as success.

This PR should make CI fail on PRs like #25991, giving some feedback on the invalid submission.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the CI label Feb 7, 2026
@zvecr zvecr merged commit e52319b into master Feb 18, 2026
2 checks passed
@zvecr zvecr deleted the zvecr-patch-4 branch February 18, 2026 00:06
edz381 pushed a commit to edz381/qmk_firmware that referenced this pull request Feb 19, 2026
elayjay pushed a commit to elayjay/qmk-firmware that referenced this pull request Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants