Skip to content

privileged mode and usb mount for devcontainer#26

Open
saesh wants to merge 1 commit intoqmk:mainfrom
saesh:fix-flash
Open

privileged mode and usb mount for devcontainer#26
saesh wants to merge 1 commit intoqmk:mainfrom
saesh:fix-flash

Conversation

@saesh
Copy link
Copy Markdown

@saesh saesh commented Jun 30, 2024

Changes

  • run devcontainer in privileged mode
  • mount /dev/bus/usb to devcontainer

Enables qmk-dfu to detect keyboard in bootloader mode inside the devcontainer.

@zvecr
Copy link
Copy Markdown
Member

zvecr commented Jun 30, 2024

Wont this change break opening in codespaces?

@saesh
Copy link
Copy Markdown
Author

saesh commented Jun 30, 2024

Wont this change break opening in codespaces?

Oh, I don't know. I only tested it locally.

As an alternative I could comment it out in the devcontainer.json and add a comment explaining the use case?

@qmk qmk deleted a comment from Qua315 Sep 5, 2024
@qmk qmk deleted a comment from Qua315 Sep 5, 2024
@tzarc
Copy link
Copy Markdown
Member

tzarc commented Jan 22, 2026

Wont this change break opening in codespaces?

Just tested it, works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants