feat: add current date to PR review metadata

[mrT23]

PR Type

Enhancement, Bug fix

---

Description

• Added validation for CLI arguments using a dedicated class.

• Encoded and decoded forbidden CLI arguments for improved security.

• Included current date in PR review metadata.

• Refactored argument validation logic for better maintainability.

---

Changes walkthrough 📝

Relevant files

Enhancement

pr_agent.py Refactored CLI argument validation logic                                  pr_agent/agent/pr_agent.py Replaced inline CLI argument validation with a call to CliArgs.validate_user_args. Removed hardcoded forbidden arguments and delegated validation to a dedicated class. Improved error handling for invalid CLI arguments. +10/-19  cli_args.py Added dedicated class for CLI argument validation                pr_agent/algo/cli_args.py Introduced CliArgs class for validating CLI arguments. Decoded forbidden arguments from base64 for added security. Implemented logic to check and reject forbidden arguments. +34/-0    pr_reviewer.py Included current date in PR metadata                                          pr_agent/tools/pr_reviewer.py Added current date to PR metadata dictionary. Used datetime.datetime.now() for date formatting. +1/-0      pr_reviewer_prompts.toml Updated prompts to include today's date                                    pr_agent/settings/pr_reviewer_prompts.toml Updated PR reviewer prompts to include today's date. Added conditional logic to display the date if available. +4/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-free-for-open-source-projects]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ No major issues detected

[qodo-free-for-open-source-projects]

PR Code Suggestions ✨

Latest suggestions up to 2887d0a

Category	Suggestion	Impact
Security	Move sensitive data to config The base64 encoded string of forbidden arguments is hardcoded and exposed in the source code. This poses a security risk as it can be easily decoded. Consider moving these sensitive configurations to a secure configuration file. pr_agent/algo/cli_args.py [11-12] -# decode forbidden args -_encoded_args = 'ZW5hYmxlX2F1dG9fYXBwcm92YWw=:YXBwcm92ZV9wcl9vbl9zZWxmX3Jldmlldw==:YmFzZV91cmw=:dXJs:YXBwX25hbWU=:c2VjcmV0X3Byb3ZpZGVy:Z2l0X3Byb3ZpZGVy:c2tpcF9rZXlz:b3BlbmFpLmtleQ==:QU5BTFlUSUNTX0ZPTERFUg==:dXJp:YXBwX2lk:d2ViaG9va19zZWNyZXQ=:YmVhcmVyX3Rva2Vu:UEVSU09OQUxfQUNDRVNTX1RPS0VO:b3ZlcnJpZGVfZGVwbG95bWVudF90eXBl:cHJpdmF0ZV9rZXk=:bG9jYWxfY2FjaGVfcGF0aA==:ZW5hYmxlX2xvY2FsX2NhY2hl:amlyYV9iYXNlX3VybA==:YXBpX2Jhc2U=:YXBpX3R5cGU=:YXBpX3ZlcnNpb24=:c2tpcF9rZXlz' +# Load forbidden args from secure configuration +forbidden_cli_args = get_settings().get('forbidden_cli_args', []) Apply this suggestion Suggestion importance[1-10]: 8 __ Why: The suggestion addresses a significant security concern by recommending moving hardcoded base64-encoded sensitive configuration data to a secure configuration file, reducing the risk of exposing sensitive parameters.	Medium
Security	Improve error handling security The error handling in validate_user_args catches all exceptions generically and returns them as strings, which could expose sensitive information. Implement specific exception handling and return a generic error message. pr_agent/algo/cli_args.py [7-32] try: if not args: return True, "" ... +except (UnicodeDecodeError, TypeError) as e: + get_logger().error(f"Error validating arguments: {e}") + return False, "Invalid argument format" except Exception as e: - return False, str(e) + get_logger().error(f"Unexpected error in argument validation: {e}") + return False, "Internal validation error" [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 8 __ Why: The suggestion addresses an important security concern by preventing potential information leakage through generic exception handling. The improved code provides more specific error handling and safer error messages.	Medium
More

---

Previous suggestions

Suggestions up to commit a07f685

Category	Suggestion	Impact
Learned best practice	Add error handling around datetime operations to gracefully handle system clock or formatting issues The current code directly calls datetime.datetime.now() without handling potential exceptions. While rare, system clock issues could cause runtime errors. Add error handling to gracefully handle datetime operation failures and provide a fallback value. pr_agent/tools/pr_reviewer.py [98] -"date": datetime.datetime.now().strftime('%Y-%m-%d'), +try: + "date": datetime.datetime.now().strftime('%Y-%m-%d'), +except Exception as e: + logger.warning(f"Failed to get current date: {e}") + "date": "N/A", Suggestion importance[1-10]: 6	Low

[KennyDizi]

/describe

[qodo-free-for-open-source-projects]

PR Description updated to latest commit (2887d0a)

• Copy walkthrough table to "Files Changed" Tab