fix(settings): restore missing large PR handling config for pr_description#2234
fix(settings): restore missing large PR handling config for pr_description#2234naorpeled merged 3 commits intoqodo-ai:mainfrom
Conversation
…ption The `enable_large_pr_handling`, `max_ai_calls`, and `async_ai_calls` keys were removed from the `[pr_description]` section in `settings/configuration.toml`, but `pr_description.py` still accesses `get_settings().pr_description.enable_large_pr_handling` at runtime. When the key is absent, an exception is raised inside `_prepare_prediction()` before `get_pr_diff` is even called. `retry_with_fallback_models()` catches it silently and logs "Failed to generate prediction", causing all configured models to exhaust in milliseconds with no actual API call ever made. Fixes qodo-ai#2230
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
|
I think https://github.com/qodo-ai/pr-agent/blob/v0.31/pr_agent/settings/configuration.toml#L122 |
|
Hey @Hank076, Could you please address the comments by @drew-simmons and me? |
|
We need this with a new release! |
Thanks for the review and feedback! |
`inline_file_summary` was missing from the `[pr_description]` section in `settings/configuration.toml`. `pr_description.py:130` accesses `get_settings().pr_description.inline_file_summary` at runtime, and the missing key causes an exception that silently fails the describe command. Fixes qodo-ai#2230
Code Review by Qodo
1. inline summary table mode missing
|
|
@naorpeled, is it possible we can go for it? |
For sure 🙏 |
|
Hi @naorpeled , The workflow is awaiting approval from a maintainer. Thanks! |
|
Thanks @Hank076! |
|
@naorpeled can we get a new release for this important fix? Many thanks! |
Hey Peter, |
|
Thank you for releasing the new version. I tried the latest v0.33, but it seems the same issue still exists for now. It might need some further investigation... |
User description
Problem
Related #2230
Running
python -m pr_agent.cli --pr_url="..." describefails immediately with:WARNING | pr_agent.algo.pr_processing:retry_with_fallback_models:333 - Failed to generate prediction with
All fallback models exhaust within a few milliseconds — no API call is
ever made.
Root Cause
pr_description.pyline 208 reads:File Walkthrough
configuration.toml
Add missing large PR handling configuration keyspr_agent/settings/configuration.toml
enable_large_pr_handling=trueconfiguration keymax_ai_calls=4configuration keyasync_ai_calls=trueconfiguration key[pr_description]section with descriptive comment