Skip to content

fix: add compliance rule for MAX_TOKENS model registry #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naorpeled wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: add compliance rule for MAX_TOKENS model registry #2281

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
966d69a
fix: add compliance rule for MAX_TOKENS model registry entries
naorpeled Mar 21, 2026
34a1ce3
fix: use review_agent extra_instructions instead of compliance checklist
naorpeled Mar 21, 2026
cf8fb2f
fix: clarify MAX_TOKENS registry exemption in AGENTS.md
naorpeled Mar 21, 2026
7f42313
Revert "fix: clarify MAX_TOKENS registry exemption in AGENTS.md"
naorpeled Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pr_agent.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ push_commands = [
[review_agent]
enabled = true
publish_output = true
extra_instructions = "The MAX_TOKENS dictionary in pr_agent/algo/__init__.py is the designated model token registry. Adding new model entries there is the expected pattern, not a hardcoded configuration violation."
Copy link
Copy Markdown
Contributor

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects bot Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. extra_instructions exceeds 120 chars 📘 Rule violation ⚙ Maintainability

The newly added extra_instructions line in .pr_agent.toml exceeds the project’s 120-character
line-length convention, creating an avoidable noisy formatting deviation. This violates the
requirement to preserve existing formatting and keep 120-character lines.
Agent Prompt 
## Issue description
The added `.pr_agent.toml` `extra_instructions` value is on a single line exceeding the repository’s 120-character line-length convention.

## Issue Context
This repository’s formatting guidance expects 120-character lines; long single-line config strings should be wrapped (e.g., via TOML multiline basic strings).

## Fix Focus Areas
- .pr_agent.toml[21-21]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Copy link
Copy Markdown
Contributor

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects bot Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Unsupported config key 🐞 Bug ✓ Correctness

.pr_agent.toml adds extra_instructions under [review_agent], but the PR review flow reads
get_settings().pr_reviewer.extra_instructions, so this new instruction will not be included in the
reviewer prompt. As a result, the intended behavior change (guidance about MAX_TOKENS) will not
take effect for /review runs in this repository.
Agent Prompt 
## Issue description
The added setting `review_agent.extra_instructions` is not used by the PR review tool implementation in this repo; the reviewer prompt consumes `pr_reviewer.extra_instructions` instead. This makes the new instruction effectively a no-op for `/review`.

## Issue Context
`PRReviewer` constructs prompt variables and explicitly sets `extra_instructions` from `get_settings().pr_reviewer.extra_instructions`.

## Fix Focus Areas
- .pr_agent.toml[18-21]
- pr_agent/tools/pr_reviewer.py[77-102]
- pr_agent/settings/configuration.toml[74-90]

## Proposed fix
Either:
1) Move/duplicate the new `extra_instructions` entry under `[pr_reviewer]` in `.pr_agent.toml` (so it is actually consumed by `PRReviewer`),

or:
2) If `review_agent` is intended to be a real tool/command in this repo, implement consumption of `get_settings().review_agent.extra_instructions` in the relevant execution path and add a corresponding defaults section in `pr_agent/settings/configuration.toml`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Loading