Skip to content

Expand and fix auto-generated file filtering in is_valid_file() #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naorpeled merged 1 commit into from
Mar 31, 2026
Merged

Expand and fix auto-generated file filtering in is_valid_file() #2289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pr_agent/algo/language_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,16 @@ def is_valid_file(filename:str, bad_extensions=None) -> bool:
if get_settings().config.use_extra_bad_extensions:
bad_extensions += get_settings().bad_extensions.extra

auto_generated_files = ['package-lock.json', 'yarn.lock', 'composer.lock', 'Gemfile.lock', 'poetry.lock']
for forbidden_file in auto_generated_files:
if filename.endswith(forbidden_file):
return False
auto_generated_files_exact = {
'package-lock.json', 'yarn.lock', 'pnpm-lock.yaml', 'composer.lock', 'Gemfile.lock',
'poetry.lock', 'go.sum', '.terraform.lock.hcl', 'uv.lock',
'Cargo.lock', 'Pipfile.lock', 'mix.lock', 'pubspec.lock', 'bun.lockb',
}
auto_generated_suffixes = ('.min.js', '.min.css', '.js.map', '.ts.map', '.css.map')
if filename.replace('\\', '/').split('/')[-1] in auto_generated_files_exact:
return False
if filename.endswith(auto_generated_suffixes):
return False

return filename.split('.')[-1] not in bad_extensions

Expand Down
Loading