[CORRUPTED] Synthetic Benchmark PR #71448 - Clean up report page styles

[tomerqodo]

User description

Benchmark PR Expensify#71448

Type: Corrupted (contains bugs)

Original PR Title: Clean up report page styles
Original PR Description:

Explanation of Change

Fixed Issues

$ Expensify#70369
PROPOSAL: Expensify#70369 (comment)

Tests

1. Go to reports page
2. Explore all the tabs in the sidebar
3. Verify list items in each tab matches the mocks in the issue description.
4. Also verify that buttons and icons in the list item like works correctly (like - view, submit, arrow down)

• Verify that no errors appear in the JS console

Offline tests

• Requires internet connection to load reports page data.

QA Steps

1. Go to reports page
2. Explore all the tabs in the sidebar
3. Verify list items in each tab matches the mocks in the issue description.
4. Also verify that buttons and icons in the list item like works correctly (like - view, submit, arrow down)

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Original PR URL: Expensify#71448

---

PR Type

Enhancement

---

Description

• Add extra-small button size support across components

• Improve report page search layout and styling for mobile

• Add accessibility labels and expand/collapse functionality

• Refactor transaction item row layout for better mobile UX

• Add new spacing and sizing utility styles

---

Diagram Walkthrough

flowchart LR
  A["Button Components"] -->|"extraSmall prop"| B["Button/Icon/Badge"]
  C["Constants"] -->|"EXTRA_SMALL size"| D["Dropdown Button Size"]
  E["Spacing Utils"] -->|"new utilities"| F["Padding/Margin Styles"]
  G["Search Components"] -->|"responsive layout"| H["Report/Card/Member Headers"]
  I["Transaction Items"] -->|"mobile optimization"| J["TransactionItemRow"]
  B --> K["Enhanced UI"]
  D --> K
  F --> K
  H --> K
  J --> K

Loading

File Walkthrough

	Relevant files
Configuration changes	1 files index.ts Add extra-small button size and accessibility labels          +7/-0
Enhancement	32 files types.ts Add extraSmall prop to dropdown button types                          +3/-0      types.ts Add extraSmall prop to settlement button types                      +3/-0      index.ts Add extra-small button styles and border styling                  +20/-2    index.ts Update icon sizing and button styling utilities                    +23/-2    spacing.ts Add new spacing utility classes                                                    +32/-0    variables.ts Add component size and width variables                                      +2/-0      index.tsx Add toggle button visibility and border styling                    +40/-18  AvatarWithDisplayName.tsx Add custom styling props for display names                              +16/-2    Badge.tsx Add XXSmall icon size support                                                        +6/-2      index.tsx Implement extra-small button size variant                                +13/-3    index.tsx Support extra-small button size in dropdown                            +5/-0      index.tsx Add extraSmall icon size parameter                                              +3/-1      MoneyRequestReportTransactionItem.tsx Add responsive padding and button press handler                    +5/-2      MoneyRequestReportTransactionList.tsx Update table padding for large screens                                      +1/-1      ParentNavigationSubtitle.tsx Add text and container styling props                                          +14/-5    index.tsx Add responsive styling for search header                                  +7/-2      index.tsx Wrap search table header with responsive container              +16/-14  ActionCell.tsx Add extra-small button support to action cell                        +9/-4      CardListItemHeader.tsx Add expand/collapse arrow for mobile view                                +34/-2    MemberListItemHeader.tsx Add expand/collapse arrow for mobile view                                +37/-3    ReportListItemHeader.tsx Reorganize layout and add expand/collapse controls              +54/-14  TotalCell.tsx Update font weight styling                                                              +1/-1      TransactionGroupListExpanded.tsx Add bottom border styling for mobile transactions                +41/-38  TransactionGroupListItem.tsx Pass expand/collapse callbacks to headers                                +27/-1    TransactionListItem.tsx Add responsive padding and right icon support                        +1/-1      UserInfoAndActionButtonRow.tsx Optimize mobile layout with responsive sizing                        +8/-4      UserInfoCell.tsx Update text styling for responsive layout                                +1/-1      UserInfoCellsWithArrow.tsx Add text indicator option and margin support                          +22/-8    WithdrawalIDListItemHeader.tsx Add expand/collapse arrow for mobile view                                +35/-2    index.tsx Support extra-small button size in settlement                        +2/-0      SearchRowSkeleton.tsx Update skeleton dimensions for mobile layout                          +23/-38  index.tsx Refactor narrow layout with improved mobile UX                      +164/-119
Tests	1 files ReportListItemHeaderTest.tsx Update test IDs for accessibility indicators                          +8/-8

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Action Not Logged: New interactive UI actions (expand/collapse toggle and various button presses) were added without any clear audit logging of these critical user interactions, which may be required depending on business rules for report/transaction views. Referred Code <View style={style}> <View style={[headerStyle, styles.flexRow, styles.alignItemsCenter]}> <View style={[styles.flex1]}>{header}</View> {shouldShowToggleButton && ( <PressableWithFeedback onPress={onPress} disabled={disabled} style={[styles.p3Half, styles.justifyContentCenter, styles.alignItemsCenter, expandButtonStyle]} accessibilityRole={CONST.ROLE.BUTTON} accessibilityLabel={isExpanded ? CONST.ACCESSIBILITY_LABELS.COLLAPSE : CONST.ACCESSIBILITY_LABELS.EXPAND} > {({hovered}) => ( <Icon src={isExpanded ? Expensicons.UpArrow : Expensicons.DownArrow} fill={theme.icon} additionalStyles={!hovered && styles.opacitySemiTransparent} small /> )} </PressableWithFeedback> )} ... (clipped 1 lines) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Missing Edge Cases: New rendering logic for borders and responsive layouts lacks null/undefined guards for arrays (e.g., columns) and callbacks, which may cause runtime issues on edge cases not visible in the diff. Referred Code /> </View> )} {visibleTransactions.map((transaction, index) => { const shouldShowBottomBorder = !isLastTransaction(index) && !isLargeScreenWidth; return ( <OfflineWithFeedback pendingAction={transaction.pendingAction} key={transaction.transactionID} > <TransactionItemRow report={transaction.report} transactionItem={transaction} violations={getTransactionViolations(transaction, violations, currentUserDetails.email ?? '')} isSelected={!!transaction.isSelected} dateColumnSize={dateColumnSize} amountColumnSize={amountColumnSize} taxAmountColumnSize={taxAmountColumnSize} shouldShowTooltip={showTooltip} shouldUseNarrowLayout={!isLargeScreenWidth} shouldShowCheckbox={!!canSelectMultiple} ... (clipped 14 lines) Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
High-level	Re-evaluate the extensive styling changes The PR's widespread styling changes, including a new 'extra-small' button and major list item refactoring, are overly complex and risky. A more targeted, less invasive approach should be considered to reduce the risk of visual regressions. Examples: src/components/TransactionItemRow/index.tsx [407-594] if (shouldUseNarrowLayout) { return ( <> <View style={[styles.expenseWidgetRadius, bgActiveStyles, styles.justifyContentEvenly, style, styles.overflowHidden]} testID="transaction-item-row" > <View style={[styles.flexRow]}> {shouldShowCheckbox && ( <Checkbox ... (clipped 178 lines) src/components/Button/index.tsx [47-391] /** Extra-small sized button */ extraSmall?: boolean; /** Small sized button */ small?: boolean; /** Large sized button */ large?: boolean; /** Medium sized button */ ... (clipped 335 lines) Solution Walkthrough: Before: // In TransactionItemRow.tsx (and many other list items) function TransactionItemRow({..., shouldUseNarrowLayout}) { if (shouldUseNarrowLayout) { return ( <View> // Layout for narrow screens <ReceiptCell /> <View> <DateCell /> <TypeCell /> <MerchantOrDescriptionCell /> <TotalCell /> </View> // ... more layout </View> ); } return ( <View> // Layout for wide screens with many columns </View> ); } After: // Suggestion implies simplifying the approach, not a specific code change. // The goal is to avoid massive refactoring in dozens of files. // A hypothetical simplified approach might look like: // In a central style/component file function createListItemStyles(isNarrow) { // Define styles more centrally } // In TransactionItemRow.tsx function TransactionItemRow({..., shouldUseNarrowLayout}) { // Reuse existing components and styles more effectively // to match mocks, rather than a full rewrite. // Avoid introducing new button sizes if possible. // Aim for more targeted changes instead of a full refactor. return ( <ListItemWrapper isNarrow={shouldUseNarrowLayout}> <Cell type="receipt" /> <Cell type="details" /> <Cell type="total" /> // ... </ListItemWrapper> ); } Suggestion importance[1-10]: 9 __ Why: This suggestion correctly identifies that the PR's extensive, widespread styling refactor across numerous components introduces significant risk and complexity, which is a critical high-level concern.	High
Possible issue	Remove incorrect style from component Remove the fromRecipientStyle from the "to" participant's UserInfoCell to fix a likely copy-paste error and prevent incorrect styling. src/components/SelectionListWithSections/Search/UserInfoCellsWithArrow.tsx [78-86] <UserInfoCell accountID={participantTo.accountID} avatar={participantTo.avatar} displayName={participantToDisplayName} avatarSize={avatarSize} textStyle={infoCellsTextStyle} avatarStyle={infoCellsAvatarStyle} - containerStyle={[styles.mw50, styles.flexShrink1, fromRecipientStyle, styles.mlHalf]} + containerStyle={[styles.mw50, styles.flexShrink1, styles.mlHalf]} /> Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion correctly identifies a potential copy-paste error where a style meant for the "from" participant is applied to the "to" participant. Removing it improves the correctness and predictability of the component's layout.	Low
General	Use predefined style for line height Replace the hardcoded lineHeight in infoCellsTextStyle with the predefined styles.textLineHeightNormal for better style consistency. src/components/SelectionListWithSections/Search/UserInfoAndActionButtonRow.tsx [58-70] <UserInfoCellsWithArrow shouldShowToRecipient={shouldShowToRecipient} participantFrom={item?.from} participantFromDisplayName={participantFromDisplayName} participantToDisplayName={participantToDisplayName} participantTo={item?.to} avatarSize={!isLargeScreenWidth ? CONST.AVATAR_SIZE.SMALL_SUBSCRIPT : CONST.AVATAR_SIZE.MID_SUBSCRIPT} style={[styles.flexRow, styles.alignItemsCenter, styles.gap1]} - infoCellsTextStyle={{lineHeight: 14}} + infoCellsTextStyle={styles.textLineHeightNormal} infoCellsAvatarStyle={styles.pr1} fromRecipientStyle={!shouldShowToRecipient ? styles.mw100 : {}} shouldUseArrowIcon={false} /> [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 5 __ Why: The suggestion correctly identifies that a hardcoded style value can be replaced with a predefined style token, which improves code consistency and maintainability.	Low
More