[CORRUPTED] Synthetic Benchmark PR #70575 - Moving workspace currency to a separate page

[tomerqodo]

User description

Benchmark PR Expensify#70575

Type: Corrupted (contains bugs)

Original PR Title: Moving workspace currency to a separate page
Original PR Description:

Explanation of Change

Fixed Issues

$ Expensify#69737
PROPOSAL: Expensify#69737 (comment)

Tests

1. in the workspace list page click on 'New workspace'
2. Validate that currency field shows default currency with symbol (e.g., "USD - $")
3. Click on the currency field
4. Select a different currency (e.g., EUR, GBP, CAD)
5. Validate that you navigate back and currency field shows the newly selected currency with symbol (e.g., "EUR - €")
6. Click on the currency field again
7. Search for invalid currency and press enter
8. Validate that nothing happens and workspace is not created
9. Search for a valid one
10. Press enter on the keyboard
11. Validate that workspace is created successfully with the selected currency

Offline tests

Same as tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-09-17.at.20.17.23.mov

Android: mWeb Chrome

Screen.Recording.2025-09-17.at.20.18.45.mov

iOS: Native

Screen.Recording.2025-09-17.at.20.17.23.mov

iOS: mWeb Safari

Screen.Recording.2025-09-17.at.20.18.45.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-17.at.20.16.25.mov

MacOS: Desktop

Screen.Recording.2025-09-17.at.20.23.34.mov

Original PR URL: Expensify#70575

---

PR Type

Enhancement

---

Description

• Add dedicated currency selection page for workspace confirmation flow

• Implement CurrencySelectionPage component with navigation integration

• Update CurrencySelector component to support currency symbol display

• Persist workspace currency selection in draft form state

• Add new route and screen definitions for currency selection modal

---

Diagram Walkthrough

flowchart LR
  A["WorkspaceConfirmationForm"] -->|navigates to| B["CurrencySelectionPage"]
  B -->|selects currency| C["setWorkspaceConfirmationCurrency"]
  C -->|persists to| D["WORKSPACE_CONFIRMATION_FORM_DRAFT"]
  D -->|updates| A
  B -->|displays| E["CurrencySelectionList"]

Loading

File Walkthrough

	Relevant files
Configuration changes	5 files ROUTES.ts Add new currency selection route definition                            +6/-0      SCREENS.ts Add currency selection screen identifier                                  +4/-0      config.ts Register currency selection in workspace confirmation navigator +1/-0      types.ts Define currency selection navigator parameter types            +3/-0      index.tsx Register currency selection page in modal stack navigator +1/-0
Enhancement	4 files Policy.ts Add function to persist workspace confirmation currency    +8/-0      CurrencySelector.tsx Enhance currency selector with symbol display and routing +29/-10  WorkspaceConfirmationForm.tsx Replace currency picker with selector and use draft values +12/-6    CurrencySelectionPage.tsx Create new dedicated currency selection page component      +66/-0

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Missing Auditing: Currency selection changes are performed (setting workspace confirmation currency) without any added logging of the action, user, or outcome, which may be considered a critical action depending on business rules. Referred Code const onSelect = useCallback( (option: CurrencyListItem) => { goBack(); setWorkspaceConfirmationCurrency(option.currencyCode); }, [goBack], ); Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Missing Edge Handling: Navigation to currency selection and processing of the selected currency lack explicit error handling for invalid or undefined currency codes and navigation failures. Referred Code didOpenCurrencySelector.current = true; if (currencySelectorRoute === ROUTES.CURRENCY_SELECTION) { Navigation.navigate(currencySelectorRoute.getRoute(Navigation.getActiveRoute()) as typeof ROUTES.SETTINGS_SUBSCRIPTION_CHANGE_PAYMENT_CURRENCY | typeof ROUTES.SETTINGS_CHANGE_CURRENCY); } else { Navigation.navigate(currencySelectorRoute as typeof ROUTES.SETTINGS_SUBSCRIPTION_CHANGE_PAYMENT_CURRENCY | typeof ROUTES.SETTINGS_CHANGE_CURRENCY); } }} /> Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Input Validation: The function setWorkspaceConfirmationCurrency writes the provided currency string to storage without validating it against allowed currency codes. Referred Code function setWorkspaceConfirmationCurrency(currency?: string) { Onyx.merge(ONYXKEYS.FORMS.WORKSPACE_CONFIRMATION_FORM_DRAFT, {currency}); } Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
High-level	Use navigation parameters for state Instead of using a global Onyx draft to manage the selected currency between screens, pass the currency back from the selection page to the confirmation form using navigation parameters. This avoids potential stale data issues by localizing the state to the navigation flow. Examples: src/pages/CurrencySelectionPage.tsx [39-45] const onSelect = useCallback( (option: CurrencyListItem) => { goBack(); setWorkspaceConfirmationCurrency(option.currencyCode); }, [goBack], ); src/components/WorkspaceConfirmationForm.tsx [88-93] const [draftValues] = useOnyx(ONYXKEYS.FORMS.WORKSPACE_CONFIRMATION_FORM_DRAFT, {canBeMissing: true}); const defaultWorkspaceName = generateDefaultWorkspaceName(policyOwnerEmail || session?.email); const [workspaceNameFirstCharacter, setWorkspaceNameFirstCharacter] = useState(defaultWorkspaceName ?? ''); const userCurrency = draftValues?.currency ?? currentUserPersonalDetails?.localCurrencyCode ?? CONST.CURRENCY.USD; Solution Walkthrough: Before: // src/pages/CurrencySelectionPage.tsx const onSelect = useCallback((option) => { goBack(); // Updates a global Onyx draft value setWorkspaceConfirmationCurrency(option.currencyCode); }, [goBack]); // src/components/WorkspaceConfirmationForm.tsx function WorkspaceConfirmationForm(...) { // Reads from the global Onyx draft value const [draftValues] = useOnyx(ONYXKEYS.FORMS.WORKSPACE_CONFIRMATION_FORM_DRAFT); const userCurrency = draftValues?.currency ?? ...; return <CurrencySelector value={userCurrency} ... />; } After: // src/pages/CurrencySelectionPage.tsx const onSelect = useCallback((option) => { // Navigates back passing the currency as a route parameter Navigation.navigate(route.params.backTo, { currency: option.currencyCode }); }, [route.params.backTo]); // src/components/WorkspaceConfirmationForm.tsx function WorkspaceConfirmationForm({ route }) { // Reads currency from route params and manages it in local state const [currency, setCurrency] = useState(route.params?.currency ?? ...); useEffect(() => { if (route.params?.currency) { setCurrency(route.params.currency); } }, [route.params?.currency]); return <CurrencySelector value={currency} ... />; } Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies a significant design flaw of using a global Onyx store for transient UI state, which can lead to data persistence bugs, and proposes a more robust, standard solution using navigation parameters.	High
Possible issue	Remove incorrect type casting for navigation Remove the incorrect and redundant type casting from the Navigation.navigate calls to improve type safety. src/components/CurrencySelector.tsx [85-89] if (currencySelectorRoute === ROUTES.CURRENCY_SELECTION) { - Navigation.navigate(currencySelectorRoute.getRoute(Navigation.getActiveRoute()) as typeof ROUTES.SETTINGS_SUBSCRIPTION_CHANGE_PAYMENT_CURRENCY | typeof ROUTES.SETTINGS_CHANGE_CURRENCY); + Navigation.navigate(currencySelectorRoute.getRoute(Navigation.getActiveRoute())); } else { - Navigation.navigate(currencySelectorRoute as typeof ROUTES.SETTINGS_SUBSCRIPTION_CHANGE_PAYMENT_CURRENCY | typeof ROUTES.SETTINGS_CHANGE_CURRENCY); + Navigation.navigate(currencySelectorRoute); } Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion correctly identifies incorrect and redundant type casting which, while not causing a runtime error, is a typing issue that harms code clarity and type safety.	Low
More