[CORRUPTED] Synthetic Benchmark PR #68929 - Update Reports page tabs (Expenses, Reports, Chats) to work without optimistic transaction thread reports

[tomerqodo]

User description

Benchmark PR Expensify#68929

Type: Corrupted (contains bugs)

Original PR Title: Update Reports page tabs (Expenses, Reports, Chats) to work without optimistic transaction thread reports
Original PR Description:

Explanation of Change

Update Reports page tabs (Expenses, Reports, Chats) to work without optimistic transaction thread reports

Fixed Issues

$ Expensify#67890
PROPOSAL: N/A

Tests

• Verify that no errors appear in the JS console

Steps to repeat before every tests block:

1. Turn on the noOptimisticTransactionThreads beta.
2. In the troubleshoot section turn on Block transaction thread report creation toggle (you can also turn it on in the troubleshoot modal CMD + D)
3. In Workspace chat create sevral expenses and an empty report
4. In 1-1 chat with user A create just on expense
5. In 1-1 chat with user B create sevral expenses

Expenses tab:

1. Go to the Reports -> Expenses tab.
2. Open any expense by tapping on the row (one transaction expense, several transactions expense)
3. Open any expense by tapping on the View button
4. Select one or several expenses that wasn't opened before (using checkboxes)
5. Open actions dropdown (Hold, Export, Delete)
6. Test Hold and make sure it works as expected.
7. Test Export and make sure it works as expected.
8. Test Delete and make sure it works as expected.
9. Select using checkbox the workspace expense that wan't opened before and Move expense to the empty report.

Reports tab:

1. Go to the Reports -> Reports tab.
2. Open multi-expense report by tapping on the report header/preview, View button in the header
3. Open one-expense report by tapping on the report header/preview, View button in the header
4. Open any expense by tapping on the View button in the expense row
5. Select one or several expenses that wasn't opened before (using checkboxes)
6. Open actions dropdown (Hold, Export, Delete)
7. Test Hold and make sure it works as expected.
8. Test Export and make sure it works as expected.
9. Test Delete and make sure it works as expected.
10. Select using checkbox the workspace expense that wan't opened before and Move expense to the empty report.

Chats tab:

1. Go to the Reports -> Chats tab.
2. Open any expense by tapping on the preview. Repeat it with a couple of expenses.

Regressions to check:
Expensify#67622

Offline tests

Same, as in the Tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

Same, as in the Tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web-chats-tab.mp4

web-reports-tab-move.mp4

web-reports-tab.mp4

web-expenses-tab.mp4

MacOS: Desktop

desktop-report-chat-tabs.mp4

desktop-expenses-tab.mp4

Original PR URL: Expensify#68929

---

PR Type

Enhancement, Tests

---

Description

• Add utility function to create and open transaction thread reports from search

• Refactor transaction thread creation logic into reusable SearchUIUtils function

• Add unit tests for createAndOpenSearchTransactionThread functionality

• Handle transaction thread report creation when opening transactions without threads

• Update SearchMoneyRequestReportPage to auto-create transaction threads on load

---

File Walkthrough

	Relevant files
Enhancement	types.ts Add isOneTransactionReport flag to transaction group type src/components/SelectionList/types.ts Add optional isOneTransactionReport boolean property to TransactionGroupListItemType Indicates whether a report contains a single transaction +3/-0      SearchUIUtils.ts Add createAndOpenSearchTransactionThread utility function src/libs/SearchUIUtils.ts Import createTransactionThreadReport, openReport from Report actions Import updateSearchResultsWithTransactionThreadReportID from Search actions Add new createAndOpenSearchTransactionThread function to handle transaction thread creation and navigation Function loads IOU report if needed and updates search results with new thread report ID Export new createAndOpenSearchTransactionThread function +16/-1    index.tsx Refactor transaction thread creation in Search component  src/components/Search/index.tsx Remove updateSearchResultsWithTransactionThreadReportID import Remove createTransactionThreadReport import Import createAndOpenSearchTransactionThread from SearchUIUtils Move transaction thread creation logic to early return in onSelectRow callback Check for UNREPORTED_REPORT_ID and create thread before navigation Simplify transaction opening logic by extracting thread creation +12/-16  TransactionGroupListItem.tsx Add transaction thread creation to TransactionGroupListItem src/components/SelectionList/Search/TransactionGroupListItem.tsx Import createAndOpenSearchTransactionThread from SearchUIUtils Import getReportAction from ReportActionsUtils Add currentSearchHash from useSearchContext hook Add check for UNREPORTED_REPORT_ID in transaction opening handler Call createAndOpenSearchTransactionThread when transaction lacks thread +9/-2      SearchMoneyRequestReportPage.tsx Auto-create transaction threads on money request report load src/pages/Search/SearchMoneyRequestReportPage.tsx Add useNetwork, usePaginatedReportActions, useTransactionsAndViolationsForReport hooks Import getAllNonDeletedTransactions, getFilteredReportActionsForReportView, getIOUActionForTransactionID, getOneTransactionThreadReportID utilities Import createTransactionThreadReport from Report actions Add logic to fetch and process report transactions and actions Auto-create transaction thread on component mount if needed Update useEffect dependency array to include transactionThreadReportID +29/-2
Tests	SearchUIUtilsTest.ts Add unit tests for transaction thread creation                      tests/unit/Search/SearchUIUtilsTest.ts Add mocks for Navigation, Report actions, and Search actions Add test suite for createAndOpenSearchTransactionThread function Test transaction thread creation and navigation flow Test IOU report loading behavior when action is missing Test search results update with new thread report ID +50/-0

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
🔴	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Missing null checks: The function assumes successful report creation and navigation without handling failures or null/undefined cases (e.g., missing report, navigation errors), leading to potential silent failures. Referred Code /** Creates transaction thread report and navigates to it from the search page */ function createAndOpenSearchTransactionThread(item: TransactionListItemType, iouReportAction: OnyxEntry<OnyxTypes.ReportAction>, hash: number, backTo: string) { // We know that iou report action exists, but it wasn't loaded yet. We need to load iou report to have the necessary data in the onyx. if (!iouReportAction) { openReport(item.report.reportID); } const transactionThreadReport = createTransactionThreadReport(item.report, iouReportAction ?? ({reportActionID: item.moneyRequestReportActionID} as OnyxTypes.ReportAction)); if (transactionThreadReport?.reportID) { updateSearchResultsWithTransactionThreadReportID(hash, item.transactionID, item.report.reportID); } Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: transactionThreadReport?.reportID, backTo})); } Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Missing auditing: New critical actions creating and opening transaction threads are not explicitly logged for audit purposes, and it’s unclear if any audit trail exists elsewhere. Referred Code /** Creates transaction thread report and navigates to it from the search page */ function createAndOpenSearchTransactionThread(item: TransactionListItemType, iouReportAction: OnyxEntry<OnyxTypes.ReportAction>, hash: number, backTo: string) { // We know that iou report action exists, but it wasn't loaded yet. We need to load iou report to have the necessary data in the onyx. if (!iouReportAction) { openReport(item.report.reportID); } const transactionThreadReport = createTransactionThreadReport(item.report, iouReportAction ?? ({reportActionID: item.moneyRequestReportActionID} as OnyxTypes.ReportAction)); if (transactionThreadReport?.reportID) { updateSearchResultsWithTransactionThreadReportID(hash, item.transactionID, item.report.reportID); } Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: transactionThreadReport?.reportID, backTo})); } Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Unvalidated inputs: Newly added flows auto-create transaction threads based on derived IDs without validating the existence/shape of transactions/actions, which may rely on assumptions not verifiable in the diff. Referred Code const isReportArchived = useReportIsArchived(report?.reportID); const {isEditingDisabled, isCurrentReportLoadedFromOnyx} = useIsReportReadyToDisplay(report, reportIDFromRoute, isReportArchived); const [scrollPosition, setScrollPosition] = useState<ScrollPosition>({}); const flatListRef = useRef<FlatList>(null); const actionListValue = useMemo((): ActionListContextType => ({flatListRef, scrollPosition, setScrollPosition}), [flatListRef, scrollPosition, setScrollPosition]); const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report?.chatReportID}`, {canBeMissing: true}); const {reportActions: unfilteredReportActions} = usePaginatedReportActions(reportIDFromRoute); const {transactions: allReportTransactions} = useTransactionsAndViolationsForReport(reportIDFromRoute); const reportActions = useMemo(() => getFilteredReportActionsForReportView(unfilteredReportActions), [unfilteredReportActions]); const reportTransactions = useMemo(() => getAllNonDeletedTransactions(allReportTransactions, reportActions), [allReportTransactions, reportActions]); const visibleTransactions = useMemo( () => reportTransactions?.filter((transaction) => isOffline || transaction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE), [reportTransactions, isOffline], ); const reportTransactionIDs = useMemo(() => visibleTransactions?.map((transaction) => transaction.transactionID), [visibleTransactions]); const transactionThreadReportID = getOneTransactionThreadReportID(report, chatReport, reportActions ?? [], isOffline, reportTransactionIDs); const oneTransactionID = reportTransactions.at(0)?.transactionID; ... (clipped 12 lines) Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Update search results with correct report ID Update the call to updateSearchResultsWithTransactionThreadReportID to pass the newly created transactionThreadReport.reportID instead of the parent item.report.reportID. src/libs/SearchUIUtils.ts [1287-1289] if (transactionThreadReport?.reportID) { - updateSearchResultsWithTransactionThreadReportID(hash, item.transactionID, item.report.reportID); + updateSearchResultsWithTransactionThreadReportID(hash, item.transactionID, transactionThreadReport.reportID); } Apply / Chat Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies a bug where the wrong report ID is used to update search results, which would lead to incorrect application state and behavior.	High
	Fix race condition during thread creation To fix a race condition, if iouReportAction is not loaded, call openReport to fetch the data and then return, rather than proceeding with a partially mocked object. src/libs/SearchUIUtils.ts [1281-1291] function createAndOpenSearchTransactionThread(item: TransactionListItemType, iouReportAction: OnyxEntry<OnyxTypes.ReportAction>, hash: number, backTo: string) { // We know that iou report action exists, but it wasn't loaded yet. We need to load iou report to have the necessary data in the onyx. if (!iouReportAction) { openReport(item.report.reportID); + // The IOU report action is not loaded yet. We have started loading it, but we will not proceed with creating the thread report at this time. + // The user can try again after the report actions are loaded. + return; } - const transactionThreadReport = createTransactionThreadReport(item.report, iouReportAction ?? ({reportActionID: item.moneyRequestReportActionID} as OnyxTypes.ReportAction)); + const transactionThreadReport = createTransactionThreadReport(item.report, iouReportAction); if (transactionThreadReport?.reportID) { - updateSearchResultsWithTransactionThreadReportID(hash, item.transactionID, item.report.reportID); + updateSearchResultsWithTransactionThreadReportID(hash, item.transactionID, transactionThreadReport.reportID); } Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID: transactionThreadReport?.reportID, backTo})); } Apply / Chat Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a race condition where an asynchronous call is not awaited, and the subsequent code relies on its result, which could lead to runtime errors.	Medium
More