[CLEAN] Synthetic Benchmark PR #5867 - Limit consolidated site access to specific site routes #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR plausible#5867
Type: Clean (correct implementation)
Original PR Title: Limit consolidated site access to specific site routes
Original PR Description: ### Changes
No visible changes in this PR, but just protecting unnecessary routes being accessed for consolidated views. A few examples:
GET /:domain/settings/peopleGET api/stats/:domain/funnels/:idPOST /sites/:domain/memberships/inviteThe idea is to update the
AuthorizeSiteAccessplug to respond with a 404 if the site in question is a consolidated view AND there's noassignexplicitly allowing consolidated view access.Tests
Changelog
Documentation
Dark mode
Original PR URL: plausible#5867