[CORRUPTED] Synthetic Benchmark PR #5909 - Slurp common test modules into exunit templates

[tomerqodo]

User description

Benchmark PR plausible#5909

Type: Corrupted (contains bugs)

Original PR Title: Slurp common test modules into exunit templates
Original PR Description: unknown
Original PR URL: plausible#5909

---

PR Type

Enhancement

---

Description

• Consolidate test module setup into ExUnit templates

• Move Plausible.Teams.Test usage into DataCase and ConnCase

• Remove redundant use Plausible statements from individual test files

• Centralize Plausible.Test.Support.HTML imports in test case templates

---

Diagram Walkthrough

flowchart LR
  A["Individual Test Files<br/>with redundant uses"] -->|"Remove duplicate<br/>use statements"| B["Cleaned Test Files"]
  C["DataCase Template"] -->|"Add Teams.Test<br/>and HTML support"| D["Enhanced DataCase"]
  E["ConnCase Template"] -->|"Add Teams.Test<br/>and HTML support"| F["Enhanced ConnCase"]
  B -->|"Inherit from"| D
  B -->|"Inherit from"| F

Loading

File Walkthrough

	Relevant files
Enhancement	79 files conn_case.ex Add Teams.Test and HTML support to ConnCase                            +4/-2      data_case.ex Add Teams.Test and HTML support to DataCase                            +3/-1      plugins_api_case.ex Reorganize module uses in PluginsAPICase                                  +2/-2      audit_test.exs Simplify module uses in audit tests                                            +1/-5      auth_test.exs Remove redundant Teams.Test usage                                                +0/-1      verification_test.exs Remove redundant use statements                                                    +0/-3      domains_test.exs Remove redundant use statements                                                    +0/-2      sso_test.exs Remove redundant use statements                                                    +0/-2      user_sessions_test.exs Remove redundant use statements                                                    +0/-2      billing_test.exs Remove redundant Teams.Test usage                                                +0/-1      enterprise_plan_test.exs Remove redundant Teams.Test usage                                                +0/-1      feature_test.exs Remove redundant Teams.Test usage                                                +0/-1      plans_test.exs Remove redundant Teams.Test usage                                                +0/-1      quota_test.exs Remove redundant use statements                                                    +0/-3      site_locker_test.exs Remove redundant Teams.Test usage                                                +0/-1      cache_test.exs Remove redundant Teams.Test usage                                                +0/-1      cache_test_sync.exs Remove redundant Teams.Test usage                                                +0/-1      consolidated_view_test.exs Reorganize module uses and imports                                              +2/-3      enterprise_plan_test.exs Remove redundant use statements                                                    +0/-1      backfill_teams_hourly_request_limit_test.exs Remove redundant Teams.Test usage                                                +0/-1      prefix_tracker_script_configuration_id_test.exs Remove redundant Teams.Test usage                                                +0/-1      funnels_test.exs Remove redundant use statements                                                    +0/-3      goals_test.exs Remove redundant use statements                                                    +0/-2      help_scout_test.exs Remove redundant use statements                                                    +0/-2      csv_importer_test.exs Remove redundant use statements                                                    +0/-2      google_analytics4_test.exs Remove redundant use statement                                                      +0/-1      imported_test.exs Remove redundant use statement                                                      +0/-1      counters_test.exs Remove redundant Teams.Test usage                                                +0/-1      event_telemetry_test.exs Remove redundant Teams.Test import                                              +0/-1      event_test.exs Remove redundant Teams.Test usage                                                +0/-1      check_test.exs Remove redundant use statement                                                      +0/-1      props_test.exs Remove redundant Teams.Test usage                                                +0/-1      purge_test.exs Remove redundant Teams.Test usage                                                +0/-1      release_test.exs Remove redundant use statement                                                      +0/-1      cache_test.exs Remove redundant Teams.Test usage                                                +0/-1      gate_keeper_test.exs Remove redundant Teams.Test usage                                                +0/-1      site_removal_test.exs Remove redundant Teams.Test usage                                                +0/-1      sites_test.exs Remove redundant use statements                                                    +0/-2      clickhouse_test.exs Remove redundant imports                                                                  +0/-2      comparisons_test.exs Remove redundant TestUtils import                                                +0/-1      consolidated_view_test.exs Remove redundant Teams.Test import                                              +0/-2      query_from_test.exs Remove redundant Teams.Test usage                                                +0/-1      query_parse_and_build_test.exs Remove redundant Teams.Test usage                                                +0/-1      query_result_test.exs Remove redundant Teams.Test usage                                                +0/-1      sampling_cache_test.exs Remove redundant use statements                                                    +0/-2      sampling_test.exs Remove redundant use statements                                                    +0/-2      grace_period_test.exs Remove redundant Teams.Test usage                                                +0/-1      accept_test.exs Remove redundant use statements                                                    +0/-2      invite_to_site_test.exs Remove redundant use statements                                                    +0/-2      invite_to_team_test.exs Remove redundant use statements                                                    +0/-2      reject_test.exs Remove redundant use statements                                                    +0/-2      remove_from_site_test.exs Remove redundant Teams.Test usage                                                +0/-1      layout_test.exs Remove redundant use statements                                                    +0/-2      leave_test.exs Remove redundant use statements                                                    +0/-2      remove_test.exs Remove redundant use statements                                                    +0/-2      update_role_test.exs Remove redundant use statements                                                    +0/-2      transfer_test.exs Remove redundant use statements                                                    +0/-2      teams_test.exs Remove redundant use statements                                                    +0/-2      billing_test.exs Remove redundant Teams.Test and HTML imports                          +0/-2      notice_test.exs Remove redundant Teams.Test usage                                                +0/-1      flow_progress_test.exs Remove redundant HTML import                                                          +0/-1      external_controller_test.exs Remove redundant Teams.Test usage                                                +0/-1      external_sites_controller_sites_crud_api_test.exs Remove redundant use statements                                                    +0/-2      external_sites_controller_test.exs Remove redundant use statements                                                    +0/-2      aggregate_test.exs Remove redundant Teams.Test and TestUtils                                +0/-2      auth_test.exs Remove redundant Teams.Test usage                                                +0/-1      breakdown_test.exs Remove redundant Teams.Test usage                                                +0/-1      query_comparisons_test.exs Remove redundant Teams.Test import                                              +0/-1      query_consolidated_view_test.exs Remove redundant Teams.Test usage                                                +0/-2      query_test.exs Remove redundant Teams.Test usage                                                +0/-1      query_timezone_test.exs Remove redundant Teams.Test usage                                                +0/-1      query_validations_test.exs Remove redundant Teams.Test usage                                                +0/-1      timeseries_test.exs Remove redundant Teams.Test usage                                                +0/-1      segments_controller_test.exs Remove redundant Teams.Test usage                                                +0/-1      sync_test.exs Remove redundant Teams.Test usage                                                +0/-1      internal_controller_test.exs Remove redundant Teams.Test usage                                                +0/-1      paddle_controller_test.exs Replace qualified TestUtils function call                                +1/-1      authorization_test.exs Remove redundant Teams.Test usage                                                +0/-1      conversions_test.exs Remove redundant Teams.Test usage                                                +0/-1
Additional files	85 files funnels_test.exs +0/-2      main_graph_test.exs +0/-1      pages_test.exs +0/-1      regions_test.exs +0/-1      sources_test.exs +0/-1      top_stats_test.exs +0/-1      auth_controller_test.exs +0/-2      billing_controller_test.exs +1/-2      error_report_controller_test.exs +0/-1      google_analytics_controller_test.exs +0/-1      help_scout_controller_test.exs +0/-3      invitation_controller_test.exs +0/-1      settings_controller_test.exs +1/-3      membership_controller_test.exs +0/-5      site_controller_test.exs +0/-2      sso_controller_sync_test.exs +0/-2      sso_controller_test.exs +0/-4      stats_controller_test.exs +0/-2      unsubscribe_controller_test.exs +0/-1      email_test.exs +0/-2      change_domain_test.exs +0/-3      choose_plan_test.exs +1/-2      combo_box_test.exs +0/-1      form_test.exs +0/-1      verification_test.exs +1/-3      sites_test.exs +0/-3      teams_test.exs +0/-3      users_test.exs +0/-3      customer_support_test.exs +0/-3      form_test.exs +0/-1      funnel_settings_test.exs +0/-3      form_test.exs +0/-2      goal_settings_sync_test.exs +0/-1      goal_settings_test.exs +0/-2      installation_test.exs +0/-3      plugins_api_tokens_test.exs +0/-1      form_test.exs +0/-2      props_settings_test.exs +0/-2      register_form_test.exs +0/-3      reset_password_form_test.exs +0/-1      form_test.exs +0/-2      shared_link_settings_test.exs +0/-2      countries_test.exs +0/-1      hostnames_test.exs +0/-1      ip_addresses_test.exs +0/-1      pages_test.exs +0/-1      sites_test.exs +0/-2      sso_management_test.exs +0/-2      team_management_test.exs +0/-2      team_setup_test.exs +0/-2      verification_test.exs +0/-1      capabilities_test.exs +0/-1      custom_props_test.exs +0/-1      funnels_test.exs +0/-2      goals_test.exs +0/-1      tracker_script_configuration_test.exs +0/-1      auth_plug_test.exs +0/-1      authorize_public_api_test.exs +0/-1      authorize_site_access_test.exs +0/-1      authorize_team_access_test.exs +0/-1      handle_expired_session_test.exs +0/-3      require_account_plug_test.exs +0/-1      sso_team_access_test.exs +0/-3      tracker_plug_test.exs +0/-1      tracker_script_cache_test.exs +0/-2      tracker_test.exs +0/-2      user_auth_test.exs +0/-2      test_schema.ex +1/-0      dev_subscriptions.ex +1/-0      accept_traffic_until_test.exs +0/-1      check_usage_test.exs +0/-1      clean_invitations_test.exs +0/-1      clickhouse_clean_sites_test.exs +0/-2      import_analytics_test.exs +0/-1      lock_sites_test.exs +0/-1      notify_annual_renewal_test.exs +0/-1      notify_exported_analytics_test.exs +0/-2      schedule_email_reports_test.exs +1/-1      send_check_stats_emails_test.exs +0/-1      send_email_report_test.exs +1/-2      send_site_setup_emails_test.exs +0/-1      send_trial_notifications_test.exs +0/-1      set_legacy_time_on_page_cutoff_test.exs +0/-2      sso_domain_verification_worker_test.exs +0/-2      traffic_change_notifier_test.exs +0/-1

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Audit relevance: The PR primarily refactors test setup and imports, with one functional change (using random_ip() on line 72); since audit trails pertain to application behavior rather than tests, there is no clear violation, but human verification is needed to confirm no audit-impacting logic changed elsewhere. Referred Code Plug.Conn.put_req_header(initial_conn, "x-forwarded-for", random_ip()) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Test-only change: The only behavioral code diff is swapping Plausible.TestUtils.random_ip() for random_ip() in a test, which does not expose missing error handling in application code; human verification is needed to confirm no production code paths were altered. Referred Code Plug.Conn.put_req_header(initial_conn, "x-forwarded-for", random_ip()) Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Add missing macro to test helper Add the missing use Plausible macro to the using block in Plausible.DataCase to prevent compilation errors in tests that rely on the on_ee macro. test/support/data_case.ex [18-27] quote do use Plausible.Repo use Plausible.TestUtils + use Plausible use Plausible.Teams.Test import Plausible.Test.Support.HTML import Ecto.Changeset import Plausible.DataCase end [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies that use Plausible was not added to Plausible.DataCase, which will cause compilation errors in many test files that were refactored to use it and contain on_ee blocks.	High
More