[CLEAN] Synthetic Benchmark PR #41217 - fix: updates the logic to not interfere with DSL when infinitescroll is enabled #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR appsmithorg#41217
Type: Clean (correct implementation)
Original PR Title: fix: updates the logic to not interfere with DSL when infinitescroll is enabled
Original PR Description:
Description
TLDR:
Refines TableWidgetV2 cell editability logic to disable editing when infinite scroll is enabled.
Problem
When people toggled infinite scroll of ON and then moved it back to ON, we were forcibly enabling editing for all columns which was wrong product behavior.
Root cause
The utilities were putting the additables to true in DSL.
And editability logic missed a check for the infinite scroll setting, causing cells to remain editable even when infinite scroll was active.
Solution
This PR handles the integration of infinite scroll support into TableWidgetV2 by updating header and cell components to respect the infiniteScrollEnabled prop. Editability is now disabled when infinite scroll is active, ensuring consistent and predictable user experience.
Fixes #
Issue Numberor
Fixes https://github.com/appsmithorg/appsmith-ee/issues/8144
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Table"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/17998257804
Commit: 4d0ff9c
Cypress dashboard.
Tags:
@tag.TableSpec:
Thu, 25 Sep 2025 06:15:12 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Original PR URL: appsmithorg#41217