Skip to content

Conversation

@tomerqodo
Copy link

Benchmark PR appsmithorg#41397

Type: Clean (correct implementation)

Original PR Title: feat: allow specifying deployment in helm chart without autoscaling
Original PR Description: ## Description

Allows specifying that the deployment of Appsmith should be done via the Deployment controller without enabling autoscaling. This is useful in situations where you want to be able to set a number of replicas without using HPAs or if you want the flexibility to set replica count to 0 to temporarily pause the instance.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Warning

Tests have not run on the HEAD 35fba39 yet


Wed, 19 Nov 2025 03:42:56 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Choice of workload type (Deployment or StatefulSet) and replicas behavior when using Deployment
    • Persistent storage now can be provisioned for Deployment workloads as well as StatefulSets
  • Documentation

    • Added guidance on workload kind, replicas usage, and interaction with autoscaling
  • Tests

    • Added tests covering persistence and workload-kind rendering scenarios
  • Chores

    • Chart version bumped to 3.6.6

Original PR URL: appsmithorg#41397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants