Skip to content

Conversation

@tomerqodo
Copy link

Benchmark PR appsmithorg#41263

Type: Corrupted (contains bugs)

Original PR Title: feat: add support for listing function versions and aliases in AWS Lambda Plugin
Original PR Description: ## Description
This PR adds support for listing AWS Lambda function versions and aliases in the plugin. It’s part of ongoing efforts to make Lambda management more robust and user-friendly for Appsmith users.

Changes

  • Introduced new commands, LIST_FUNCTION_VERSIONS and LIST_FUNCTION_ALIASES, to the AwsLambdaPlugin, enabling retrieval of function versions and aliases.
  • Updated invoke.json to support optional fields for specifying function version and alias, improving invocation flexibility.
  • Added dedicated JSON configuration files for listing function versions and aliases, streamlining command usage and future extensibility.
  • Enhanced the plugin’s test suite to cover the new commands, ensuring correct behavior for version and alias retrieval.
  • These changes align with our broader goal of making cloud integrations more manageable and transparent, especially as we scale Appsmith’s automation capabilities.

Testing

Automated tests have been added to the plugin’s test suite, specifically targeting the new version and alias listing functionalities. These tests verify correct command execution and output structure.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/18035977310
Commit: 0148b54
Cypress dashboard.
Tags: @tag.Datasource
Spec:


Fri, 26 Sep 2025 11:49:19 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • List AWS Lambda function versions and aliases; invoke by selecting a version or alias (alias takes precedence).
    • New dynamic dropdowns for Function Version and Function Alias tied to the selected function; command menu adds "List Function Versions" and "List Function Aliases."
    • Trigger menus now return option lists for FUNCTION_NAMES/FUNCTION_VERSIONS/FUNCTION_ALIASES.
    • Added UI editor sections for listing versions and aliases.
  • Tests

    • Added tests for listing versions/aliases, invoking with version/alias, trigger behavior, and validation.

Original PR URL: appsmithorg#41263

rahulbarwal and others added 10 commits September 25, 2025 17:50
…mbda Plugin

- Implemented new commands `LIST_FUNCTION_VERSIONS` and `LIST_FUNCTION_ALIASES` in the AwsLambdaPlugin to retrieve function versions and aliases respectively.
- Updated the invoke.json to include optional fields for function version and alias.
- Created new JSON files for listing function versions and aliases with appropriate configurations.
- Enhanced the plugin's test suite to cover the new functionalities, ensuring correct behavior for version and alias retrieval.

This update improves the AWS Lambda Plugin's capabilities, allowing users to manage function versions and aliases more effectively.
- Changed the method of retrieving the function name parameter from `request.getParams()` to `request.getParameters()` for better type safety and consistency.
- This update ensures that the function name is correctly fetched as a String, preventing potential runtime errors.

This fix enhances the reliability of the AWS Lambda Plugin's functionality related to function versions and aliases.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
….com:appsmithorg/appsmith into rahulbarwal/aws-lambda-version-functionality
…ases (appsmithorg#41267)

## Description
- Enhanced the AwsLambdaPlugin to support both old and new parameter
structures for retrieving function names in FUNCTION_VERSIONS and
FUNCTION_ALIASES requests.
- Updated the invoke.json to reflect the new parameter structure,
ensuring compatibility with the updated logic.

This change improves the robustness of the plugin by accommodating
different parameter formats, preventing potential errors during function
name retrieval.
Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants